chore(actors-sdk-embed): auto-build & install manager dependencies #1964
+39
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2025
Closed
Closed
This was referenced Jan 30, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the actors SDK build process by automating dependency management and improving build reliability, particularly focusing on the manager component's build pipeline.
- Added Yarn installation verification in
/packages/toolchain/actors-sdk-embed/build.rsto fail early if dependencies can't be installed - Implemented automatic manager dependency installation with
--immutableflag in/packages/toolchain/actors-sdk-embed/build.rs - Removed redundant Deno/Yarn installation steps from
/packages/toolchain/js-utils-embed/build.rsto streamline the build process - Added explicit build step for
@rivet-gg/actor-managerusing project root filtering
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+19
to
+21
| ensure!( | ||
| yarn_check.is_ok() && yarn_check.unwrap().success(), | ||
| "yarn is not installed, please install yarn to build this project" |
There was a problem hiding this comment.
style: unwrap() after is_ok() check is redundant and could be simplified to yarn_check?.success()
Suggested change
| ensure!( | |
| yarn_check.is_ok() && yarn_check.unwrap().success(), | |
| "yarn is not installed, please install yarn to build this project" | |
| ensure!( | |
| yarn_check?.success(), | |
| "yarn is not installed, please install yarn to build this project" |
| @@ -83,6 +118,8 @@ pub async fn build_backend_command_raw(opts: CommandOpts) -> Result<()> { | |||
| // Serialize command | |||
| let input_json = serde_json::to_string(&opts.input)?; | |||
|
|
|||
| // Yarn install | |||
There was a problem hiding this comment.
style: empty 'Yarn install' comment should be removed since it's not followed by any code
Deploying rivet with
|
| Latest commit: |
6489694
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://777a4a52.rivet.pages.dev |
| Branch Preview URL: | https://01-29-chore-actors-sdk-embed.rivet.pages.dev |
This was referenced Jan 30, 2025
Closed
Merge activity
|
NathanFlurry
added a commit
that referenced
this pull request
Jan 30, 2025
…1964) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
01-29-chore_actors-sdk-embed_auto-build_install_manager_dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes