feat(sdks/actor/runtime): include url for debugging actor in internal error metadata #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2025
Closed
Deploying rivet with
|
| Latest commit: |
d2eaad4
|
| Status: | 🚫 Build failed. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances actor debugging capabilities by adding error metadata URLs that link directly to specific actor instances in the Rivet Hub.
- Added
InternalErrorMetadatainterface insdks/actor/runtime/src/errors.tsto include debugging URLs - Modified error handling in
sdks/actor/runtime/src/actor.tsto include actor-specific Hub URLs in error metadata - Updated
sdks/actor/runtime/src/event.tsto pass actorMetadata and construct debugging URLs for WebSocket errors - Enhanced error logging with additional context (connectionId, rpcRequestId, rpcName)
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
sdks/actor/runtime/src/actor.ts
Outdated
Comment on lines
518
to
526
| metadata = { | ||
| url: `https://hub.rivet.gg/projects/${this._metadata.project.slug}/environments/${this._metadata.environment.slug}/actors?actorId=${this._metadata.actor.id}`, | ||
| } satisfies errors.InternalErrorMetadata; |
There was a problem hiding this comment.
logic: URL construction assumes project.slug and environment.slug are always available. Should handle case where metadata fields are undefined.
NathanFlurry
force-pushed
the
01-27-feat_sdks_actor_runtime_include_url_for_debugging_actor_in_internal_error_metadata
branch
from
9485632 to
d2eaad4
Compare
This was referenced Jan 28, 2025
NathanFlurry
force-pushed
the
01-27-feat_sdks_actor_runtime_include_url_for_debugging_actor_in_internal_error_metadata
branch
from
2ea6c4b to
d2eaad4
Compare
Deploying rivet-hub with
|
| Latest commit: |
d2eaad4
|
| Status: | 🚫 Build failed. |
NathanFlurry
force-pushed
the
01-27-feat_sdks_actor_runtime_include_url_for_debugging_actor_in_internal_error_metadata
branch
from
c5aac86 to
d2eaad4
Compare
NathanFlurry
force-pushed
the
01-27-feat_sdks_actor_runtime_include_url_for_debugging_actor_in_internal_error_metadata
branch
from
6cf3ff7 to
d2eaad4
Compare
This was referenced Jan 30, 2025
Closed
Merge activity
|
NathanFlurry
added a commit
that referenced
this pull request
Jan 30, 2025
… error metadata (#1952) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
01-27-feat_sdks_actor_runtime_include_url_for_debugging_actor_in_internal_error_metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes