Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update examples #1936

Closed
wants to merge 1 commit into from
Closed

Conversation

NathanFlurry
Copy link
Member

Changes

Copy link

cloudflare-workers-and-pages bot commented Jan 23, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59447fd
Status: ✅  Deploy successful!
Preview URL: https://f3274b19.rivet.pages.dev
Branch Preview URL: https://01-22-chore-update-examples.rivet.pages.dev

View logs

Copy link
Member Author

NathanFlurry commented Jan 23, 2025


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR modifies the JavaScript counter example by converting the test file into a demo script and adding a new execution method via shell script.

  • Changed /examples/javascript/counter/counter_test.ts from a test suite to a demonstration script by removing assertions and adding console.log statements
  • Added /examples/javascript/counter/run.sh with potentially concerning -A and --unstable-sloppy-imports flags
  • Consider renaming counter_test.ts to counter_demo.ts to better reflect its new purpose

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -0,0 +1,2 @@
#!/bin/sh
deno run -A --unstable-sloppy-imports counter_test.ts
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: The -A flag grants all permissions (network, file, env, etc) which may be overly permissive. Consider restricting to only required permissions (--allow-net, --allow-read etc).

@NathanFlurry NathanFlurry force-pushed the 01-22-chore_update_examples branch from ed9ac0f to 59447fd Compare January 28, 2025 16:23
Copy link
Contributor

graphite-app bot commented Jan 30, 2025

Merge activity

  • Jan 30, 3:38 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 30, 3:42 AM EST: CI is running for this PR on a draft PR: #1974
  • Jan 30, 3:45 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1974.

NathanFlurry added a commit that referenced this pull request Jan 30, 2025
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Jan 30, 2025
@graphite-app graphite-app bot deleted the 01-22-chore_update_examples branch January 30, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant