-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update examples #1936
chore: update examples #1936
Conversation
Deploying rivet with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR modifies the JavaScript counter example by converting the test file into a demo script and adding a new execution method via shell script.
- Changed
/examples/javascript/counter/counter_test.ts
from a test suite to a demonstration script by removing assertions and adding console.log statements - Added
/examples/javascript/counter/run.sh
with potentially concerning-A
and--unstable-sloppy-imports
flags - Consider renaming
counter_test.ts
tocounter_demo.ts
to better reflect its new purpose
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
@@ -0,0 +1,2 @@ | |||
#!/bin/sh | |||
deno run -A --unstable-sloppy-imports counter_test.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: The -A flag grants all permissions (network, file, env, etc) which may be overly permissive. Consider restricting to only required permissions (--allow-net, --allow-read etc).
ed9ac0f
to
59447fd
Compare
Merge activity
|
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Changes