-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(site): remove use of assert { type: ... }
for better nodejs compat
#1962
Closed
NathanFlurry
wants to merge
1
commit into
01-29-chore_sdks_actor_runtime_remove_legacy_version_check
from
01-29-fix_site_remove_use_of_assert_type_._for_better_nodejs_compat
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2025
Closed
This was referenced Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Removed unused JSON imports with assert { type: 'json' }
syntax from navigation generation script to improve Node.js compatibility.
- Commented out unused imports
apiPages
andengineStyles
in/site/scripts/generateNavigation.mjs
for better Node.js compatibility - No functional changes as these imports were not being used in the navigation generation process
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with Cloudflare Pages
|
This was referenced Jan 30, 2025
Closed
Merge activity
|
NathanFlurry
added a commit
that referenced
this pull request
Jan 30, 2025
…pat (#1962) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
01-29-fix_site_remove_use_of_assert_type_._for_better_nodejs_compat
branch
January 30, 2025 08:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes