Bug: Synonym sync: Redundant whitespace

[joeflack4]

Resolves #733

Overview

Now JOINing Mondo and source on the lowercasing + redundant-whitespace-removed variation of synonym strings. Also for -added, will now be removing redundant whitespace from synonyms.

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

• Yes
• No, updates to the docs were not necessary after careful consideration

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after
docker pull obolibrary/odkfull:dev), and no errors occurred?

• Yes
  • Mini build: Synonym Sync - Redundant whitespace - mini build #739
  • Build: DO NOT MERGE: Synonym Sync - Redundant whitespace - build #741
• No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

New Packages

Were any new Python packages added?

• Yes, requirements.txt.full was updated and an ODK issue submitted
• No

Were any other non-Python packages added?

• Yes, Dockerfile updated and an ODK issue submitted
• No

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

• Yes

[twhetzel]

Looks good!

[joeflack4]

@matentzn Just need your approval on this PR now. Pretty simple task: it just removes redundant whitespace from synonyms. This was causing an issue where we were not able to JOIN between Mondo and source terms sometimes.

[twhetzel]

@joeflack4 do you have a specific question on this PR you are waiting on Nico for? Remember he is busy on other projects for Q1.

[joeflack4]

@twhetzel Ah, you mentioned that. But I assumed he'd still be reviewing. Nothing specific. Do we want to do 1 reviewer only until some time in Feb, Mar, or April?

[matentzn]

I would suggest for now at least to only ask a review of me if Trish is uncertain about something.. I have a terrible month in terms of competing priorities and while I am committed to always do everything, things will be severely delayed..

In the same vein it would be good if super high priority tasks (reviews, issues, questions) are always pushed to me on slack.