New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Synonym sync: Redundant whitespace #733

Open

joeflack4 opened this issue Dec 19, 2024 · 0 comments · May be fixed by #738

Assignees

Labels

bug

Contributor

joeflack4 commented Dec 19, 2024 •

edited by twhetzel

Loading

Overview

There are synonyms from sources that have redundant whitespace (beginning, middle, or end of string).

Need to do:

Modify the JOIN: Do on "lowercasing + stripped" rather than just lowercasing.
Fix source synonyms: Remove redundant whitespace

This is needed to fix one of the Mondo qc check failures from adding "reports/sync-synonym/sync-synonyms.added.robot.tsv" into Mondo based on this test PR monarch-initiative/mondo#8463. The failures due to double whitespace are here: https://github.com/monarch-initiative/mondo/actions/runs/12089789637/job/33715669723?pr=8463#step:4:50

joeflack4 added the bug label

joeflack4 self-assigned this

joeflack4 linked a pull request

that will close this issue

Bug: Synonym sync: Redundant whitespace #738

Open

9 tasks

joeflack4 linked a pull request

that will close this issue

Bug: Synonym sync: Redundant whitespace #738

Open

9 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment