Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_utils): fix the right bound assignment in resamplePath #6020

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jan 6, 2024

Description

Fixed the bug of the right bound assignment in resamplePath of autoware_auto_planning_msgs::msg::Path.

Tests performed

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jan 6, 2024
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 6, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review January 6, 2024 18:23
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5de111f) 15.23% compared to head (22f9b85) 15.23%.

Files Patch % Lines
common/motion_utils/src/resample/resample.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6020   +/-   ##
=======================================
  Coverage   15.23%   15.23%           
=======================================
  Files        1751     1751           
  Lines      120918   120918           
  Branches    36770    36770           
=======================================
+ Hits        18421    18424    +3     
+ Misses      81825    81824    -1     
+ Partials    20672    20670    -2     
Flag Coverage Δ *Carryforward flag
differential 18.33% <0.00%> (?)
total 15.23% <ø> (+<0.01%) ⬆️ Carriedforward from 5de111f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 enabled auto-merge (squash) January 6, 2024 21:40
@takayuki5168 takayuki5168 disabled auto-merge January 7, 2024 04:48
@takayuki5168 takayuki5168 merged commit 4784c33 into autowarefoundation:main Jan 7, 2024
39 of 41 checks passed
@takayuki5168 takayuki5168 deleted the fix/resample-bound-bug-fix branch January 7, 2024 04:48
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants