Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_centerline_optimizer): fix several bugs and refactor the code #6022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jan 6, 2024

Description

Fixed the several bugs of static_centerline_optimizer

  • Added a path_smoother' optimization in the static_centerline_optimizer which was removed unexpectedly when the path_smoother package was separated from the obstacle_avoidance_planner.
  • Added lanelet::utils::overwriteLaneletsCenterline(map_ptr, 5.0, false);, which is called from the map_loader package, to make the planning's behavior the same as the usual path planning of the Autoware.
  • resampled the path with the same interval of the behavior_path_planner (2.0 by yaml) and behavior_velocity_planner (1.0 by hard coding).
  • Changed to call the optimization calculation of the initial settings several times
    • since the initial optimization is sometimes unstable due to the warm start.

Refactored the static_centerline_optimizer

  • removed successive_trajectory_optimizer_node.cpp/hpp by
    • adding getter functions of the optimizers in the path_smoother/obstacle_avoidance_planner packages
    • creating their nodes and optimizers' instances by calling the getter functions from the nodes

Tests performed

offline centerline generation + psim.
TIER IV internal ticket: https://tier4.atlassian.net/browse/RT1-2252

Effects on system behavior

Some bugs are fixed.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 6, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review January 6, 2024 21:46
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 6, 2024
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 force-pushed the fix/static-centerline-optimizer-bugs-main branch from dfe3905 to 436533b Compare January 7, 2024 09:12
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (eb09f68) 15.22% compared to head (436533b) 15.25%.

Files Patch % Lines
...optimizer/src/static_centerline_optimizer_node.cpp 41.07% 1 Missing and 32 partials ⚠️
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6022      +/-   ##
==========================================
+ Coverage   15.22%   15.25%   +0.02%     
==========================================
  Files        1751     1751              
  Lines      120898   120944      +46     
  Branches    36778    36806      +28     
==========================================
+ Hits        18407    18449      +42     
+ Misses      81813    81784      -29     
- Partials    20678    20711      +33     
Flag Coverage Δ *Carryforward flag
differential 33.28% <43.33%> (?)
total 15.22% <ø> (-0.01%) ⬇️ Carriedforward from eb09f68

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit e2dd5c4 into autowarefoundation:main Jan 8, 2024
22 of 24 checks passed
@takayuki5168 takayuki5168 deleted the fix/static-centerline-optimizer-bugs-main branch January 8, 2024 14:28
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…ode (autowarefoundation#6022)

* fix(static_centerline_optimizer): fix several bugs and refactor the code

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…ode (autowarefoundation#6022)

* fix(static_centerline_optimizer): fix several bugs and refactor the code

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…ode (autowarefoundation#6022)

* fix(static_centerline_optimizer): fix several bugs and refactor the code

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ode (autowarefoundation#6022)

* fix(static_centerline_optimizer): fix several bugs and refactor the code

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants