-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(static_centerline_optimizer): fix several bugs and refactor the code #6022
Merged
takayuki5168
merged 3 commits into
autowarefoundation:main
from
tier4:fix/static-centerline-optimizer-bugs-main
Jan 8, 2024
Merged
fix(static_centerline_optimizer): fix several bugs and refactor the code #6022
takayuki5168
merged 3 commits into
autowarefoundation:main
from
tier4:fix/static-centerline-optimizer-bugs-main
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Jan 6, 2024
takayuki5168
requested review from
kosuke55,
maxime-clem and
TakaHoribe
as code owners
January 6, 2024 21:46
takayuki5168
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jan 6, 2024
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
force-pushed
the
fix/static-centerline-optimizer-bugs-main
branch
from
January 7, 2024 09:12
dfe3905
to
436533b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6022 +/- ##
==========================================
+ Coverage 15.22% 15.25% +0.02%
==========================================
Files 1751 1751
Lines 120898 120944 +46
Branches 36778 36806 +28
==========================================
+ Hits 18407 18449 +42
+ Misses 81813 81784 -29
- Partials 20678 20711 +33
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…ode (autowarefoundation#6022) * fix(static_centerline_optimizer): fix several bugs and refactor the code Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…ode (autowarefoundation#6022) * fix(static_centerline_optimizer): fix several bugs and refactor the code Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…ode (autowarefoundation#6022) * fix(static_centerline_optimizer): fix several bugs and refactor the code Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ode (autowarefoundation#6022) * fix(static_centerline_optimizer): fix several bugs and refactor the code Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the several bugs of static_centerline_optimizer
lanelet::utils::overwriteLaneletsCenterline(map_ptr, 5.0, false);
, which is called from the map_loader package, to make the planning's behavior the same as the usual path planning of the Autoware.Refactored the static_centerline_optimizer
Tests performed
offline centerline generation + psim.
TIER IV internal ticket: https://tier4.atlassian.net/browse/RT1-2252
Effects on system behavior
Some bugs are fixed.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.