Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript Integration in /simulator/src files #414

Open
niladrix719 opened this issue Jan 21, 2025 · 4 comments · May be fixed by #422, #426, #427, #425 or #424
Open

Typescript Integration in /simulator/src files #414

niladrix719 opened this issue Jan 21, 2025 · 4 comments · May be fixed by #422, #426, #427, #425 or #424
Labels
good first issue Good for newcomers

Comments

@niladrix719
Copy link
Member

We have already started to migrate the javascript files to typescript, but some are yet to be converted

mainly inside of the /simulator/src dir

Pull requests should be made for each files separately feel free to open pull requests
@niladrix719 niladrix719 added the good first issue Good for newcomers label Jan 21, 2025
@nickhil-verma
Copy link

@niladrix719 assign me this issue

This was referenced Jan 22, 2025
Draft
Open
Open
@niladrix719
Copy link
Member Author

@nickhil-verma go ahead

@adityanandanx
Copy link

Hey @niladrix719
I think the PR #416 once merged will significantly help identifying ts and eslint errors which will help solve this issue faster.
Our first approach should be to reduce(Ideally remove) the use of any for variable declarations rather than just converting js files into ts files where many variables use any as their type.

Let me know your thoughts on this
Thanks

@ThatDeparted2061
Copy link

ThatDeparted2061 commented Jan 22, 2025 •
edited
Loading

We can firstly try to avoid using any in the file conversion,
secondly using linting would set us back, for js and ts file work different in property declarations etc, this wud need us to first change the declarations of many properties we were using earlier for js files. That ll take a lot of time.

We already have many declaration issues to work upon.

@ThatDeparted2061 ThatDeparted2061 linked a pull request Jan 22, 2025 that will close this issue
Open
@nickhil-verma nickhil-verma linked a pull request Jan 22, 2025 that will close this issue
Open
This was referenced Jan 22, 2025
Open
Open
Open
This was referenced Jan 23, 2025
Open
Open
This was referenced Jan 23, 2025
Open
Open
Open
Open
Open
Open
Draft
This was referenced Jan 25, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JS to TS : simulator/src/data/load.ts #422 nickhil-verma/cv-frontend-vue
JS to TS : simulator/src/app.ts nickhil-verma/cv-frontend-vue
JS to TS : simulator/src/canvasApi.ts nickhil-verma/cv-frontend-vue
JS to TS: src/simulator/src/hotkey_binder/model/shortcuts.plugin.ts ThatDeparted2061/cv-frontend-vue
JS to TS : src/simulator/src/hotkey_binder/model/addShortcut.ts ThatDeparted2061/cv-frontend-vue
JS to TS simulator/src/hotkey_binder/model/actions.ts ThatDeparted2061/cv-frontend-vue
JS to TS : simulator/src/data/undo.ts ThatDeparted2061/cv-frontend-vue
JS to Ts : simulator/src/data/saveImage.ts ThatDeparted2061/cv-frontend-vue
Js to TS : simulator/src/data/redo.ts ThatDeparted2061/cv-frontend-vue
refactor: JS to TS : src/simulator/src/hotkey_binder/model/utils.js ThatDeparted2061/cv-frontend-vue
4 participants
@adityanandanx @niladrix719 @nickhil-verma @ThatDeparted2061