-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(turbo-tasks): Filter out and do not cache unused arguments #75261
base: canary
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Failing test suitesCommit: 25ef396
Expand output● logging-incoming-request › should handle disabled request logging
Read more about building and testing Next.js in contributing.md.
Expand output● bigint API route support › development mode › should return 200
● bigint API route support › development mode › should return the BigInt result text
Read more about building and testing Next.js in contributing.md.
Expand output● Rewritten API Requests should pass OPTIONS requests to the api function › should pass OPTIONS requests to the api function
Read more about building and testing Next.js in contributing.md.
Expand output● API routes › dev support › should return data when catch-all
● API routes › dev support › should return data when catch-all with index and trailing slash
● API routes › dev support › should return data when catch-all with index and no trailing slash
Read more about building and testing Next.js in contributing.md.
Expand output● disabled runtime JS › development mode › should render the page
● disabled runtime JS › development mode › should not have NEXT_DATA script
Read more about building and testing Next.js in contributing.md.
Expand output● hmr-app-and-pages › should do HMR when app router and pages router have shared CSS
Read more about building and testing Next.js in contributing.md.
Expand output● Default 404 Page with custom _error › development mode › should respond to 404 correctly
● Default 404 Page with custom _error › development mode › should render error correctly
● Default 404 Page with custom _error › development mode › should render index page normal
Read more about building and testing Next.js in contributing.md.
Expand output● gsp-gssp › development mode › shows error with getServerSideProps in pages/500 dev
Read more about building and testing Next.js in contributing.md.
Expand output● dynamic-requests warnings › warnings on sync cookie access
● dynamic-requests warnings › warnings on sync draftMode access
● dynamic-requests warnings › warnings on sync headers access
● dynamic-requests warnings › warnings on sync params access
● dynamic-requests warnings › warnings on sync searchParams access
Read more about building and testing Next.js in contributing.md.
Expand output● app dir - with output export - dynamic missing gsp prod › production mode › should error when dynamic route is missing generateStaticParams
Read more about building and testing Next.js in contributing.md.
Expand output● app-root-params - simple › should return rootParams
● app-root-params - simple › should only return rootParams and not other params
Read more about building and testing Next.js in contributing.md.
Expand output● app dir - basepath › should successfully hard navigate from pages -> app
● app dir - basepath › should support
● app dir - basepath › should support Link with basePath prefixed
● app dir - basepath › should prefix metadata og image with basePath
● app dir - basepath › should prefix redirect() with basePath
● app dir - basepath › should render usePathname without the basePath
● app dir - basepath › should handle redirect in dynamic in suspense boundary routes with basePath
● app dir - basepath › should only make a single RSC call to the current page (/base/refresh)
● app dir - basepath › should only make a single RSC call to the current page (/base/refresh?foo=bar)
● app dir - basepath › should properly stream an internal server action redirect() with a relative URL
● app dir - basepath › should properly stream an internal server action redirect() with a absolute URL
● app dir - basepath › should redirect externally when encountering absolute URLs on the same host outside the basePath
Read more about building and testing Next.js in contributing.md.
Expand output● 404 Page Support SSG › production mode › should build successfully
● 404 Page Support SSG › production mode › should respond to 404 correctly
● 404 Page Support SSG › production mode › should render error correctly
● 404 Page Support SSG › production mode › should not show an error in the logs for 404 SSG
● 404 Page Support SSG › production mode › should render index page normal
● 404 Page Support SSG › production mode › should not revalidate custom 404 page
● 404 Page Support SSG › production mode › should set pages404 in routes-manifest correctly
● 404 Page Support SSG › production mode › should have 404 page in prerender-manifest
Read more about building and testing Next.js in contributing.md.
Expand output● output: standalone with app dir › should handle trace files correctly for route groups (nodejs only)
● output: standalone with app dir › should work correctly with output standalone
Read more about building and testing Next.js in contributing.md.
Expand output● Root components import order › production mode › _app chunks should be attached to de dom before page chunks
● Root components import order › production mode › root components should be imported in this order _document > _app > page in order to respect side effects
Read more about building and testing Next.js in contributing.md.
Expand output● AMP Validation on Export › production mode › should have shown errors during build
Read more about building and testing Next.js in contributing.md.
Expand output● async-component-preload › should handle redirect in an async page
Read more about building and testing Next.js in contributing.md.
Expand output● actions-revalidate-remount › should not remount the page + loading component when revalidating
Read more about building and testing Next.js in contributing.md.
Expand output● next-config-ts - turbopack › should work with Turbopack
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir - async-client-component › app router client component async module
Read more about building and testing Next.js in contributing.md.
Expand output● Error Overlay version staleness › should show version staleness in runtime error
● Error Overlay version staleness › should show version staleness in render error
● Error Overlay version staleness › should show version staleness in build error
Read more about building and testing Next.js in contributing.md. |
a7429b6
to
40fd0db
Compare
4dcf00f
to
f22bdcd
Compare
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js bgw/filter-unused-args | Change | |
---|---|---|---|
buildDuration | 18.4s | 16.1s | N/A |
buildDurationCached | 15.3s | 13.2s | N/A |
nodeModulesSize | 419 MB | 419 MB | ✓ |
nextStartRea..uration (ms) | 426ms | 424ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js bgw/filter-unused-args | Change | |
---|---|---|---|
5306-HASH.js gzip | 54.1 kB | 54.1 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.46 kB | 5.46 kB | N/A |
bccd1874-HASH.js gzip | 52.9 kB | 52.9 kB | N/A |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 240 B | 242 B | N/A |
main-HASH.js gzip | 34.6 kB | 34.6 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js bgw/filter-unused-args | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js bgw/filter-unused-args | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.59 kB | 4.58 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.35 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js bgw/filter-unused-args | Change | |
---|---|---|---|
_buildManifest.js gzip | 748 B | 747 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js bgw/filter-unused-args | Change | |
---|---|---|---|
index.html gzip | 523 B | 523 B | ✓ |
link.html gzip | 538 B | 539 B | N/A |
withRouter.html gzip | 518 B | 521 B | N/A |
Overall change | 523 B | 523 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js bgw/filter-unused-args | Change | |
---|---|---|---|
edge-ssr.js gzip | 129 kB | 129 kB | N/A |
page.js gzip | 210 kB | 210 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js bgw/filter-unused-args | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 671 B | 665 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.3 kB | 31.3 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js bgw/filter-unused-args | Change | |
---|---|---|---|
274-experime...dev.js gzip | 322 B | 322 B | ✓ |
274.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 378 kB | 378 kB | ✓ |
app-page-exp..prod.js gzip | 132 kB | 132 kB | ✓ |
app-page-tur..prod.js gzip | 145 kB | 145 kB | ✓ |
app-page-tur..prod.js gzip | 141 kB | 141 kB | ✓ |
app-page.run...dev.js gzip | 365 kB | 365 kB | ✓ |
app-page.run..prod.js gzip | 128 kB | 128 kB | ✓ |
app-route-ex...dev.js gzip | 37.6 kB | 37.6 kB | ✓ |
app-route-ex..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
app-route.ru...dev.js gzip | 39.2 kB | 39.2 kB | ✓ |
app-route.ru..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.9 kB | 21.9 kB | ✓ |
pages.runtim...dev.js gzip | 27.7 kB | 27.7 kB | ✓ |
pages.runtim..prod.js gzip | 21.9 kB | 21.9 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
Overall change | 2.49 MB | 2.49 MB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js bgw/filter-unused-args | Change | |
---|---|---|---|
0.pack gzip | 2.1 MB | 2.1 MB | |
index.pack gzip | 75.1 kB | 75.5 kB | |
Overall change | 2.18 MB | 2.18 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
40fd0db
to
2a987b0
Compare
f22bdcd
to
28e47be
Compare
2a987b0
to
dd12daa
Compare
28e47be
to
25ef396
Compare
51a826a
to
35fc3ed
Compare
25ef396
to
c8519e8
Compare
35fc3ed
to
0151e49
Compare
c8519e8
to
5c57296
Compare
0151e49
to
0c17996
Compare
5c57296
to
3e43193
Compare
0c17996
to
7578b8f
Compare
3e43193
to
3b47071
Compare
No description provided.