Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(turbo-tasks): Mark a bunch of stuff as local #75260

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from
Draft

Conversation

bgw
Copy link
Member

@bgw bgw commented Jan 24, 2025

See if any tests break.

TODO: Cross-referencing with cache hits on dev, benchmarking...

Copy link
Member Author

bgw commented Jan 24, 2025

@bgw bgw added the CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci label Jan 24, 2025 — with Graphite App
@ijjk
Copy link
Member

ijjk commented Jan 24, 2025

Failing test suites

Commit: 3d794ae

pnpm test test/integration/env-config/test/index.test.js (turbopack)

  • Env Config > development mode > with hot reload > should trigger HMR correctly when NEXT_PUBLIC_ env is changed
Expand output

● Env Config › development mode › with hot reload › should trigger HMR correctly when NEXT_PUBLIC_ env is changed

TIMED OUT: replaced

another

undefined

  735 |
  736 |   if (hardError) {
> 737 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  738 |   }
  739 |   return false
  740 | }

  at check (lib/next-test-utils.ts:737:11)
  at Object.<anonymous> (integration/env-config/test/index.test.js:315:13)

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/amp-export-validation/test/index.test.js (turbopack)

  • AMP Validation on Export > production mode > should have shown errors during build
Expand output

● AMP Validation on Export › production mode › should have shown errors during build

expect(received).toMatch(expected)

Expected pattern: /error.*The mandatory attribute 'height' is missing in tag 'amp-video'\./
Received string:  "   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   ▲ Next.js 15.2.0-canary.25 (Turbopack)·
   Checking validity of types ...
   Creating an optimized production build ...
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Building (0/7) ...
   Building (1/7)··
   Building (3/7)··
   Building (5/7)··
 ✓ Building (7/7)
 ✓ Compiled successfully in 2.9s
   Collecting page data ...
   Generating static pages (0/8) ...
   Generating static pages (2/8)··
 ⚠ Linting is disabled.
Error occurred prerendering page \"/third\". Read more: https://nextjs.org/docs/messages/prerender-error
AssertionError: Assertion failed: WebAssembly is uninitialized

  at new module$contents$goog$asserts_AssertionError (../evalmachine.<anonymous>:106:1695)
  at module$contents$goog$asserts_doAssertFailure (../evalmachine.<anonymous>:107:354)
  at goog.asserts.assertExists (../evalmachine.<anonymous>:109:142)
  at Object.module$contents$amp$validator_validateString [as validateString] (../evalmachine.<anonymous>:2663:108)
  at Validator.validateString (../packages/next/dist/compiled/amphtml-validator/index.js:1:20650)
  at validateAmp (../packages/next/dist/export/routes/pages.js:87:34)
  at async exportPagesPage (../packages/next/dist/export/routes/pages.js:121:17)
  at async Span.traceAsyncFn (../packages/next/dist/trace/trace.js:156:20)
  at async exportPage (../packages/next/dist/export/worker.js:344:18)
  Export encountered an error on /third, exiting the build.
   ⨯ Static worker exited with code: 1 and signal: null
  "
  at Object.toMatch (integration/amp-export-validation/test/index.test.js:28:29)

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/invalid-revalidate-values/test/index.test.js (turbopack)

  • Invalid revalidate values > should not show error for false revalidate value
  • Invalid revalidate values > should not show error for true revalidate value
  • Invalid revalidate values > should show error for string revalidate value
  • Invalid revalidate values > should show error for null revalidate value
  • Invalid revalidate values > should show error for float revalidate value
Expand output

● Invalid revalidate values › should not show error for false revalidate value

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  33 |   })
  34 |
> 35 |   it('should not show error for false revalidate value', async () => {
     |   ^
  36 |     pageFile.replace('revalidate: 1', 'revalidate: false')
  37 |
  38 |     try {

  at it (integration/invalid-revalidate-values/test/index.test.js:35:3)
  at Object.describe (integration/invalid-revalidate-values/test/index.test.js:20:1)

● Invalid revalidate values › should not show error for true revalidate value

Failed to replace content.

Pattern: revalidate: 1

Content: export default function Page() {
  return (
    <>
      <p>a-ok</p>
    </>
  )
}

export const getStaticProps = () => {
  return {
    props: {
      hello: 'world',
    },
    revalidate: false,
  }
}

  768 |     } else if (typeof pattern === 'string') {
  769 |       if (!currentContent.includes(pattern)) {
> 770 |         throw new Error(
      |               ^
  771 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  772 |         )
  773 |       }

  at File.replace (lib/next-test-utils.ts:770:15)
  at Object.replace (integration/invalid-revalidate-values/test/index.test.js:50:14)

● Invalid revalidate values › should show error for string revalidate value

Failed to replace content.

Pattern: revalidate: 1

Content: export default function Page() {
  return (
    <>
      <p>a-ok</p>
    </>
  )
}

export const getStaticProps = () => {
  return {
    props: {
      hello: 'world',
    },
    revalidate: false,
  }
}

  768 |     } else if (typeof pattern === 'string') {
  769 |       if (!currentContent.includes(pattern)) {
> 770 |         throw new Error(
      |               ^
  771 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  772 |         )
  773 |       }

  at File.replace (lib/next-test-utils.ts:770:15)
  at Object.replace (integration/invalid-revalidate-values/test/index.test.js:64:14)

● Invalid revalidate values › should show error for null revalidate value

Failed to replace content.

Pattern: revalidate: 1

Content: export default function Page() {
  return (
    <>
      <p>a-ok</p>
    </>
  )
}

export const getStaticProps = () => {
  return {
    props: {
      hello: 'world',
    },
    revalidate: false,
  }
}

  768 |     } else if (typeof pattern === 'string') {
  769 |       if (!currentContent.includes(pattern)) {
> 770 |         throw new Error(
      |               ^
  771 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  772 |         )
  773 |       }

  at File.replace (lib/next-test-utils.ts:770:15)
  at Object.replace (integration/invalid-revalidate-values/test/index.test.js:77:14)

● Invalid revalidate values › should show error for float revalidate value

Failed to replace content.

Pattern: revalidate: 1

Content: export default function Page() {
  return (
    <>
      <p>a-ok</p>
    </>
  )
}

export const getStaticProps = () => {
  return {
    props: {
      hello: 'world',
    },
    revalidate: false,
  }
}

  768 |     } else if (typeof pattern === 'string') {
  769 |       if (!currentContent.includes(pattern)) {
> 770 |         throw new Error(
      |               ^
  771 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  772 |         )
  773 |       }

  at File.replace (lib/next-test-utils.ts:770:15)
  at Object.replace (integration/invalid-revalidate-values/test/index.test.js:90:14)

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/server-side-dev-errors/test/index.test.js (turbopack)

  • server-side dev errors > should show server-side error for gsp page correctly
  • server-side dev errors > should show server-side error for gssp page correctly
Expand output

● server-side dev errors › should show server-side error for gsp page correctly

Expected no Redbox but found one
header: 1 of 1 issue
Next.js (15.2.0-canary.25) (Turbopack)
Server Error

ReferenceError: missingVar is not defined

This error happened while generating the page. Any console logs will be displayed in the terminal window.
description: ReferenceError: missingVar is not defined
source: ../../test/integration/server-side-dev-errors/pages/gsp.js (6:3) @ getStaticProps

  4 |
  5 | export async function getStaticProps() {
> 6 |   missingVar;return {
    |   ^
  7 |     props: {},
  8 |   }
  9 | }

  92 |       expect(await getRedboxSource(browser)).toContain('missingVar')
  93 |       await fs.writeFile(gspPage, content, { flush: true })
> 94 |       await assertNoRedbox(browser)
     |       ^
  95 |     } finally {
  96 |       await fs.writeFile(gspPage, content)
  97 |     }

  at Object.<anonymous> (integration/server-side-dev-errors/test/index.test.js:94:7)

● server-side dev errors › should show server-side error for gssp page correctly

Expected no Redbox but found one
header: 1 of 1 issue
Next.js (15.2.0-canary.25) (Turbopack)
Server Error

ReferenceError: missingVar is not defined

This error happened while generating the page. Any console logs will be displayed in the terminal window.
description: ReferenceError: missingVar is not defined
source: ../../test/integration/server-side-dev-errors/pages/gssp.js (6:3) @ getServerSideProps

  4 |
  5 | export async function getServerSideProps() {
> 6 |   missingVar;return {
    |   ^
  7 |     props: {},
  8 |   }
  9 | }

  142 |       expect(await getRedboxSource(browser)).toContain('missingVar')
  143 |       await fs.writeFile(gsspPage, content)
> 144 |       await assertNoRedbox(browser)
      |       ^
  145 |     } finally {
  146 |       await fs.writeFile(gsspPage, content)
  147 |     }

  at Object.<anonymous> (integration/server-side-dev-errors/test/index.test.js:144:7)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev-turbo test/development/app-dir/hmr-asset-prefix-full-url/asset-prefix.test.ts (turbopack)

  • app-dir assetPrefix full URL > should not break HMR when asset prefix set to full URL
Expand output

● app-dir assetPrefix full URL › should not break HMR when asset prefix set to full URL

expect(received).toBe(expected) // Object.is equality

Expected: "after edit"
Received: "before edit"

  27 |
  28 |     await retry(async () => {
> 29 |       expect(await browser.elementByCss('p').text()).toBe('after edit')
     |                                                      ^
  30 |     })
  31 |   })
  32 | })

  at toBe (development/app-dir/hmr-asset-prefix-full-url/asset-prefix.test.ts:29:54)
  at retry (lib/next-test-utils.ts:810:14)
  at Object.<anonymous> (development/app-dir/hmr-asset-prefix-full-url/asset-prefix.test.ts:28:5)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev-turbo test/development/acceptance-app/ReactRefreshModule.test.ts (turbopack)

  • ReactRefreshModule app > should allow any variable names
Expand output

● ReactRefreshModule app › should allow any variable names

Application is in inconsistent state: timeout.

  93 |             }
  94 |             if (status !== 'pending') {
> 95 |               throw new Error(
     |                     ^
  96 |                 `Application is in inconsistent state: ${status}.`
  97 |               )
  98 |             }

  at Object.patch (lib/development-sandbox.ts:95:21)
  at Object.<anonymous> (development/acceptance-app/ReactRefreshModule.test.ts:26:7)

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/typescript-hmr/test/index.test.js (turbopack)

  • TypeScript HMR > should ignore type errors in development
  • TypeScript HMR > delete a page and add it back > should detect the changes to typescript pages and display it
Expand output

● TypeScript HMR › delete a page and add it back › should detect the changes to typescript pages and display it

TIMED OUT: /COOL page/

Hello World

undefined

  735 |
  736 |   if (hardError) {
> 737 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  738 |   }
  739 |   return false
  740 | }

  at check (lib/next-test-utils.ts:737:11)
  at Object.<anonymous> (integration/typescript-hmr/test/index.test.js:52:9)

● TypeScript HMR › should ignore type errors in development

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  115 |       )
  116 |
> 117 |       expect(res).toBe(true)
      |                   ^
  118 |     } finally {
  119 |       if (browser) browser.close()
  120 |       await fs.writeFile(pagePath, origContent)

  at Object.toBe (integration/typescript-hmr/test/index.test.js:117:19)

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/read-only-source-hmr/test/index.test.js (turbopack)

  • Read-only source HMR > should detect changes to a page
  • Read-only source HMR > should handle page deletion and subsequent recreation
Expand output

● Read-only source HMR › should detect changes to a page

TIMED OUT: /COOL page/

Hello World

undefined

  735 |
  736 |   if (hardError) {
> 737 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  738 |   }
  739 |   return false
  740 | }

  at check (lib/next-test-utils.ts:737:11)
  at Object.<anonymous> (integration/read-only-source-hmr/test/index.test.js:74:7)

● Read-only source HMR › should handle page deletion and subsequent recreation

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  83 |   })
  84 |
> 85 |   it('should handle page deletion and subsequent recreation', async () => {
     |   ^
  86 |     let browser
  87 |
  88 |     try {

  at it (integration/read-only-source-hmr/test/index.test.js:85:3)
  at Object.describe (integration/read-only-source-hmr/test/index.test.js:37:1)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev-turbo test/development/acceptance-app/editor-links.test.ts (turbopack)

  • Error overlay - editor links > should be possible to open source file on build error
Expand output

● Error overlay - editor links › should be possible to open source file on build error

Application is in inconsistent state: timeout.

  93 |             }
  94 |             if (status !== 'pending') {
> 95 |               throw new Error(
     |                     ^
  96 |                 `Application is in inconsistent state: ${status}.`
  97 |               )
  98 |             }

  at Object.patch (lib/development-sandbox.ts:95:21)
  at Object.<anonymous> (development/acceptance-app/editor-links.test.ts:60:5)

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/jsconfig-baseurl/test/index.test.js (turbopack)

  • jsconfig.json baseurl > default behavior > should have correct module not found error
  • jsconfig.json baseurl > should build > production mode > should trace correctly
Expand output

● jsconfig.json baseurl › default behavior › should have correct module not found error

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  45 |     })
  46 |
> 47 |     it('should have correct module not found error', async () => {
     |     ^
  48 |       const basicPage = join(appDir, 'pages/hello.js')
  49 |       const contents = await fs.readFile(basicPage, 'utf8')
  50 |

  at it (integration/jsconfig-baseurl/test/index.test.js:47:5)
  at describe (integration/jsconfig-baseurl/test/index.test.js:26:3)
  at Object.describe (integration/jsconfig-baseurl/test/index.test.js:25:1)

● jsconfig.json baseurl › should build › production mode › should trace correctly

command failed with code 1 signal null
 ⚠ Linting is disabled.
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/jsconfig-baseurl/next.config.js
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/jsconfig-baseurl/next.config.js
   ▲ Next.js 15.2.0-canary.25 (Turbopack)

   Checking validity of types ...
   Creating an optimized production build ...
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/jsconfig-baseurl/next.config.js
   Building (0/2) ...
 ✓ Building (2/2)

> Build error occurred
Error: Turbopack build failed with 1 errors:
Page: {"type":"pages","side":"server","page":"/hello"}
./test/integration/jsconfig-baseurl/pages/hello.js:2:1
Module not found: Can't resolve 'components/worldd'
  1 | import React from 'react'
> 2 | import { World } from 'components/worldd'
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  3 |
  4 | // prevent static generation for trace test
  5 | export function getServerSideProps() {



https://nextjs.org/docs/messages/module-not-found

  at <unknown> (integration/jsconfig-baseurl/pages/hello.js:2:1)
      at <unknown> (https://nextjs.org/docs/messages/module-not-found)
  at turbopackBuild (../dist/build/index.js:924:49)
  at async (../dist/build/index.js:964:89)
  at async Span.traceAsyncFn (../dist/trace/trace.js:156:20)
  at async build (../dist/build/index.js:372:9)
  at ChildProcess.<anonymous> (lib/next-test-utils.ts:314:11)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev-turbo test/development/acceptance-app/ReactRefresh.test.ts (turbopack)

  • ReactRefresh app > can edit a component without losing state
  • ReactRefresh app > cyclic dependencies
Expand output

● ReactRefresh app › can edit a component without losing state

Application is in inconsistent state: timeout.

  93 |             }
  94 |             if (status !== 'pending') {
> 95 |               throw new Error(
     |                     ^
  96 |                 `Application is in inconsistent state: ${status}.`
  97 |               )
  98 |             }

  at Object.patch (lib/development-sandbox.ts:95:21)
  at Object.<anonymous> (development/acceptance-app/ReactRefresh.test.ts:17:5)

● ReactRefresh app › cyclic dependencies

Application is in inconsistent state: timeout.

  93 |             }
  94 |             if (status !== 'pending') {
> 95 |               throw new Error(
     |                     ^
  96 |                 `Application is in inconsistent state: ${status}.`
  97 |               )
  98 |             }

  at Object.patch (lib/development-sandbox.ts:95:21)
  at Object.<anonymous> (development/acceptance-app/ReactRefresh.test.ts:167:28)

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/app-document-remove-hmr/test/index.test.js (turbopack)

  • _app removal HMR > should HMR when _app is removed
  • _app removal HMR > should HMR when _document is removed
Expand output

● _app removal HMR › should HMR when _app is removed

TIMED OUT: success

<head><meta charset="utf-8" data-next-head=""><meta name="viewport" content="width=device-width" data-next-head=""><noscript data-n-css=""></noscript><script src="/_next/static/chunks/packages_next_dist_compiled_d4dc90._.js" defer=""></script><script src="/_next/static/chunks/packages_next_dist_shared_lib_cd2c78._.js" defer=""></script><script src="/_next/static/chunks/packages_next_dist_client_d15b13._.js" defer=""></script><script src="/_next/static/chunks/packages_next_dist_04dd8f._.js" defer=""></script><script src="/_next/static/chunks/packages_next_app_1d3324.js" defer=""></script><script src="/_next/static/chunks/test_integration_app-document-remove-hmr_pages__app_6c205e._.js" defer=""></script><script src="/_next/static/chunks/%5Broot%20of%20the%20server%5D__f97c22._.js" defer=""></script><script src="/_next/static/chunks/node_modules__pnpm_182135._.js" defer=""></script><script src="/_next/static/chunks/test_integration_app-document-remove-hmr_pages__app_5771e1._.js" defer=""></script><script src="/_next/static/chunks/test_integration_app-document-remove-hmr_pages__app_610f93._.js" defer=""></script><script src="/_next/static/chunks/packages_next_dist_29c433._.js" defer=""></script><script src="/_next/static/chunks/test_integration_app-document-remove-hmr_pages_c8bddd._.js" defer=""></script><script src="/_next/static/chunks/%5Broot%20of%20the%20server%5D__7c0a5e._.js" defer=""></script><script src="/_next/static/chunks/node_modules__pnpm_d46910._.js" defer=""></script><script src="/_next/static/chunks/test_integration_app-document-remove-hmr_pages_index_5771e1._.js" defer=""></script><script src="/_next/static/chunks/test_integration_app-document-remove-hmr_pages_index_ea291e._.js" defer=""></script><script src="/_next/static/development/_ssgManifest.js" defer=""></script><script src="/_next/static/development/_buildManifest.js" defer=""></script><noscript id="__next_css__DO_NOT_USE__"></noscript></head><body><p>custom _document</p><div id="__next"><p>index page</p></div><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/","query":{},"buildId":"development","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script><div id="__next-build-indicator" style="position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;"></div><next-route-announcer><p aria-live="assertive" id="__next-route-announcer__" role="alert" style="border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; top: 0px; width: 1px; white-space: nowrap; overflow-wrap: normal;"></p></next-route-announcer></body>

undefined

  735 |
  736 |   if (hardError) {
> 737 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  738 |   }
  739 |   return false
  740 | }

  at check (lib/next-test-utils.ts:737:11)
  at Object.<anonymous> (integration/app-document-remove-hmr/test/index.test.js:49:7)

● _app removal HMR › should HMR when _document is removed

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  73 |   })
  74 |
> 75 |   it('should HMR when _document is removed', async () => {
     |   ^
  76 |     let indexContent = await fs.readFile(indexPage)
  77 |     try {
  78 |       const browser = await webdriver(appPort, '/')

  at it (integration/app-document-remove-hmr/test/index.test.js:75:3)
  at Object.describe (integration/app-document-remove-hmr/test/index.test.js:16:1)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev-turbo test/development/acceptance/ReactRefresh.test.ts (turbopack)

  • ReactRefresh > can edit a component without losing state
  • ReactRefresh > cyclic dependencies
Expand output

● ReactRefresh › can edit a component without losing state

Application is in inconsistent state: timeout.

  93 |             }
  94 |             if (status !== 'pending') {
> 95 |               throw new Error(
     |                     ^
  96 |                 `Application is in inconsistent state: ${status}.`
  97 |               )
  98 |             }

  at Object.patch (lib/development-sandbox.ts:95:21)
  at Object.<anonymous> (development/acceptance/ReactRefresh.test.ts:40:5)

● ReactRefresh › cyclic dependencies

Application is in inconsistent state: timeout.

  93 |             }
  94 |             if (status !== 'pending') {
> 95 |               throw new Error(
     |                     ^
  96 |                 `Application is in inconsistent state: ${status}.`
  97 |               )
  98 |             }

  at Object.patch (lib/development-sandbox.ts:95:21)
  at Object.<anonymous> (development/acceptance/ReactRefresh.test.ts:153:5)

Read more about building and testing Next.js in contributing.md.

pnpm test-start-turbo test/e2e/persistent-caching/persistent-caching.test.ts (turbopack)

  • persistent-caching > should persistent cache loaders
  • persistent-caching > should allow to change files while stopped
Expand output

● persistent-caching › should persistent cache loaders

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  32 |   }
  33 |
> 34 |   it('should persistent cache loaders', async () => {
     |   ^
  35 |     let appTimestamp, pagesTimestamp
  36 |     {
  37 |       const browser = await next.browser('/')

  at it (e2e/persistent-caching/persistent-caching.test.ts:34:3)
  at Object.describe (e2e/persistent-caching/persistent-caching.test.ts:4:1)

● persistent-caching › should allow to change files while stopped

page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:39591/
Call log:
  - navigating to "http://localhost:39591/", waiting until "load"

  282 |     opts?.beforePageLoad?.(page)
  283 |
> 284 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  285 |   }
  286 |
  287 |   back(options) {

  at BrowserInterface.goto (lib/browsers/playwright.ts:284:16)
  at webdriver (lib/next-webdriver.ts:136:3)
  at Object.<anonymous> (e2e/persistent-caching/persistent-caching.test.ts:64:23)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Jan 24, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/mark-local Change
buildDuration 19.3s 15.3s N/A
buildDurationCached 14s 11.3s N/A
nodeModulesSize 389 MB 389 MB
nextStartRea..uration (ms) 487ms 397ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/mark-local Change
5306-HASH.js gzip 54.1 kB 54.1 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.6 kB 34.6 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/mark-local Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js bgw/mark-local Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/mark-local Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/mark-local Change
index.html gzip 523 B 523 B
link.html gzip 538 B 539 B N/A
withRouter.html gzip 518 B 521 B N/A
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/mark-local Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js bgw/mark-local Change
middleware-b..fest.js gzip 670 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js bgw/mark-local Change
app-page-exp...dev.js gzip 308 kB 308 kB N/A
app-page-exp..prod.js gzip 131 kB 131 kB
app-page-tur..prod.js gzip 144 kB 144 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page.run...dev.js gzip 300 kB 300 kB N/A
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 31.8 kB 31.8 kB
app-route-ex..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 24.8 kB 24.8 kB
app-route.ru...dev.js gzip 33.1 kB 33.1 kB
app-route.ru..prod.js gzip 24.8 kB 24.8 kB
dist_client_...dev.js gzip 314 B 314 B
dist_client_...dev.js gzip 307 B 307 B
pages-api-tu..prod.js gzip 8.81 kB 8.81 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 8.8 kB 8.8 kB
pages-turbo...prod.js gzip 21.6 kB 21.6 kB
pages.runtim...dev.js gzip 26.1 kB 26.1 kB
pages.runtim..prod.js gzip 21.6 kB 21.6 kB
server.runti..prod.js gzip 73.7 kB 73.7 kB
Overall change 879 kB 879 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/mark-local Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +469 B
index.pack gzip 75.8 kB 75.6 kB N/A
Overall change 2.1 MB 2.1 MB ⚠️ +469 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: 3d794ae

@bgw bgw force-pushed the bgw/fn-local-option branch from 40fd0db to 2a987b0 Compare January 24, 2025 17:46
@bgw bgw force-pushed the bgw/fn-local-option branch from 2a987b0 to dd12daa Compare January 24, 2025 18:33
@bgw bgw force-pushed the bgw/fn-local-option branch 2 times, most recently from 51a826a to 35fc3ed Compare January 24, 2025 19:18
@bgw bgw force-pushed the bgw/fn-local-option branch from 35fc3ed to 0151e49 Compare January 24, 2025 19:24
@bgw bgw force-pushed the bgw/fn-local-option branch from 0151e49 to 0c17996 Compare January 24, 2025 22:05
@bgw bgw changed the base branch from bgw/fn-local-option to graphite-base/75260 January 24, 2025 22:29
@bgw bgw force-pushed the graphite-base/75260 branch from 0c17996 to 7578b8f Compare January 24, 2025 22:30
@bgw bgw changed the base branch from graphite-base/75260 to canary January 24, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants