-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(turbo-tasks): Mark a bunch of stuff as local #75260
base: canary
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Failing test suitesCommit: 3d794ae
Expand output● Env Config › development mode › with hot reload › should trigger HMR correctly when NEXT_PUBLIC_ env is changed
Read more about building and testing Next.js in contributing.md.
Expand output● AMP Validation on Export › production mode › should have shown errors during build
Read more about building and testing Next.js in contributing.md.
Expand output● Invalid revalidate values › should not show error for false revalidate value
● Invalid revalidate values › should not show error for true revalidate value
● Invalid revalidate values › should show error for string revalidate value
● Invalid revalidate values › should show error for null revalidate value
● Invalid revalidate values › should show error for float revalidate value
Read more about building and testing Next.js in contributing.md.
Expand output● server-side dev errors › should show server-side error for gsp page correctly
● server-side dev errors › should show server-side error for gssp page correctly
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir assetPrefix full URL › should not break HMR when asset prefix set to full URL
Read more about building and testing Next.js in contributing.md.
Expand output● ReactRefreshModule app › should allow any variable names
Read more about building and testing Next.js in contributing.md.
Expand output● TypeScript HMR › delete a page and add it back › should detect the changes to typescript pages and display it
● TypeScript HMR › should ignore type errors in development
Read more about building and testing Next.js in contributing.md.
Expand output● Read-only source HMR › should detect changes to a page
● Read-only source HMR › should handle page deletion and subsequent recreation
Read more about building and testing Next.js in contributing.md.
Expand output● Error overlay - editor links › should be possible to open source file on build error
Read more about building and testing Next.js in contributing.md.
Expand output● jsconfig.json baseurl › default behavior › should have correct module not found error
● jsconfig.json baseurl › should build › production mode › should trace correctly
Read more about building and testing Next.js in contributing.md.
Expand output● ReactRefresh app › can edit a component without losing state
● ReactRefresh app › cyclic dependencies
Read more about building and testing Next.js in contributing.md.
Expand output● _app removal HMR › should HMR when _app is removed
● _app removal HMR › should HMR when _document is removed
Read more about building and testing Next.js in contributing.md.
Expand output● ReactRefresh › can edit a component without losing state
● ReactRefresh › cyclic dependencies
Read more about building and testing Next.js in contributing.md.
Expand output● persistent-caching › should persistent cache loaders
● persistent-caching › should allow to change files while stopped
Read more about building and testing Next.js in contributing.md. |
a7429b6
to
40fd0db
Compare
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js bgw/mark-local | Change | |
---|---|---|---|
buildDuration | 19.3s | 15.3s | N/A |
buildDurationCached | 14s | 11.3s | N/A |
nodeModulesSize | 389 MB | 389 MB | ✓ |
nextStartRea..uration (ms) | 487ms | 397ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js bgw/mark-local | Change | |
---|---|---|---|
5306-HASH.js gzip | 54.1 kB | 54.1 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.46 kB | 5.46 kB | N/A |
bccd1874-HASH.js gzip | 52.9 kB | 52.9 kB | N/A |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 240 B | 242 B | N/A |
main-HASH.js gzip | 34.6 kB | 34.6 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js bgw/mark-local | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js bgw/mark-local | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.59 kB | 4.58 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.35 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js bgw/mark-local | Change | |
---|---|---|---|
_buildManifest.js gzip | 748 B | 747 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js bgw/mark-local | Change | |
---|---|---|---|
index.html gzip | 523 B | 523 B | ✓ |
link.html gzip | 538 B | 539 B | N/A |
withRouter.html gzip | 518 B | 521 B | N/A |
Overall change | 523 B | 523 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js bgw/mark-local | Change | |
---|---|---|---|
edge-ssr.js gzip | 129 kB | 129 kB | N/A |
page.js gzip | 210 kB | 210 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js bgw/mark-local | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 670 B | 666 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.3 kB | 31.3 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js bgw/mark-local | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 308 kB | 308 kB | N/A |
app-page-exp..prod.js gzip | 131 kB | 131 kB | ✓ |
app-page-tur..prod.js gzip | 144 kB | 144 kB | ✓ |
app-page-tur..prod.js gzip | 140 kB | 140 kB | ✓ |
app-page.run...dev.js gzip | 300 kB | 300 kB | N/A |
app-page.run..prod.js gzip | 128 kB | 128 kB | ✓ |
app-route-ex...dev.js gzip | 31.8 kB | 31.8 kB | ✓ |
app-route-ex..prod.js gzip | 25 kB | 25 kB | ✓ |
app-route-tu..prod.js gzip | 25 kB | 25 kB | ✓ |
app-route-tu..prod.js gzip | 24.8 kB | 24.8 kB | ✓ |
app-route.ru...dev.js gzip | 33.1 kB | 33.1 kB | ✓ |
app-route.ru..prod.js gzip | 24.8 kB | 24.8 kB | ✓ |
dist_client_...dev.js gzip | 314 B | 314 B | ✓ |
dist_client_...dev.js gzip | 307 B | 307 B | ✓ |
pages-api-tu..prod.js gzip | 8.81 kB | 8.81 kB | ✓ |
pages-api.ru...dev.js gzip | 9.82 kB | 9.82 kB | ✓ |
pages-api.ru..prod.js gzip | 8.8 kB | 8.8 kB | ✓ |
pages-turbo...prod.js gzip | 21.6 kB | 21.6 kB | ✓ |
pages.runtim...dev.js gzip | 26.1 kB | 26.1 kB | ✓ |
pages.runtim..prod.js gzip | 21.6 kB | 21.6 kB | ✓ |
server.runti..prod.js gzip | 73.7 kB | 73.7 kB | ✓ |
Overall change | 879 kB | 879 kB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js bgw/mark-local | Change | |
---|---|---|---|
0.pack gzip | 2.1 MB | 2.1 MB | |
index.pack gzip | 75.8 kB | 75.6 kB | N/A |
Overall change | 2.1 MB | 2.1 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
40fd0db
to
2a987b0
Compare
2a987b0
to
dd12daa
Compare
51a826a
to
35fc3ed
Compare
35fc3ed
to
0151e49
Compare
0151e49
to
0c17996
Compare
0c17996
to
7578b8f
Compare
See if any tests break.
TODO: Cross-referencing with cache hits on dev, benchmarking...