chore(turbo-tasks): Remove argument resolution from backends, only allow local-task-based argument resolution #75214

bgw · 2025-01-23T05:49:20Z

Removes the (now default) feature flag for local task argument resolution.

With local-task based argument resolution in place, we don't need to support argument resolution in the backend, which simplifies some code.

Closes PACK-3812

bgw · 2025-01-23T05:49:41Z

perf(turbo-tasks): Add a 'local' option to #[turbo_tasks::function(..)] #75259 : 2 dependent PRs (#75260 , #75261 )
refactor(turbo-tasks): Merge dynamic_call/native_call with dynamic_this_call/native_this_call #75253
chore(turbo-tasks): Remove argument resolution from backends, only allow local-task-based argument resolution #75214 👈 (View in Graphite)
chore(turbo-tasks): Delete non_local_return support from #[turbo_tasks::function] #75209
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

ijjk · 2025-01-23T06:01:19Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js bgw/rm-backend-argument-resolution	Change
buildDuration	17.7s	15.5s	N/A
buildDurationCached	14.7s	12.4s	N/A
nodeModulesSize	419 MB	419 MB	✓
nextStartRea..uration (ms)	397ms	398ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js bgw/rm-backend-argument-resolution	Change
5306-HASH.js gzip	54.1 kB	54.1 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	240 B	242 B	N/A
main-HASH.js gzip	34.6 kB	34.6 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bgw/rm-backend-argument-resolution	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bgw/rm-backend-argument-resolution	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bgw/rm-backend-argument-resolution	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bgw/rm-backend-argument-resolution	Change
index.html gzip	523 B	523 B	✓
link.html gzip	538 B	539 B	N/A
withRouter.html gzip	518 B	521 B	N/A
Overall change	523 B	523 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js bgw/rm-backend-argument-resolution	Change
edge-ssr.js gzip	129 kB	129 kB	N/A
page.js gzip	210 kB	210 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js bgw/rm-backend-argument-resolution	Change
middleware-b..fest.js gzip	667 B	666 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js bgw/rm-backend-argument-resolution	Change
274-experime...dev.js gzip	322 B	322 B	✓
274.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	378 kB	378 kB	✓
app-page-exp..prod.js gzip	132 kB	132 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	365 kB	365 kB	✓
app-page.run..prod.js gzip	128 kB	128 kB	✓
app-route-ex...dev.js gzip	37.6 kB	37.6 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	39.2 kB	39.2 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.6 kB	11.6 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	27.7 kB	27.7 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.49 MB	2.49 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bgw/rm-backend-argument-resolution	Change
0.pack gzip	2.1 MB	2.1 MB	N/A
index.pack gzip	75 kB	76.3 kB	⚠️ +1.37 kB
Overall change	75 kB	76.3 kB	⚠️ +1.37 kB

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: 0f70ca4

ijjk · 2025-01-24T05:01:51Z

Tests Passed

sokra · 2025-01-24T07:35:53Z

turbopack/crates/turbo-tasks/src/backend.rs

 }

-impl Display for CachedTaskType {
+// Manual implementation is needed because of a borrow issue with `Box<dyn Trait>`:


Weird that derive worked with the enum, but not with a struct

sokra · 2025-01-24T07:36:28Z

turbopack/crates/turbo-tasks/src/backend.rs

+            s.serialize_element(&())?;
+            s.serialize_element(&())?;


Suggested change

s.serialize_element(&())?;

s.serialize_element(&())?;

sokra · 2025-01-24T07:36:43Z

turbopack/crates/turbo-tasks/src/backend.rs

+                    let () = seq
+                        .next_element()?
+                        .ok_or_else(|| serde::de::Error::invalid_length(2, &self))?;
+                    let () = seq
+                        .next_element()?
+                        .ok_or_else(|| serde::de::Error::invalid_length(3, &self))?;


Suggested change

let () = seq

.next_element()?

.ok_or_else(|| serde::de::Error::invalid_length(2, &self))?;

let () = seq

.next_element()?

.ok_or_else(|| serde::de::Error::invalid_length(3, &self))?;

sokra · 2025-01-24T07:36:57Z

turbopack/crates/turbo-tasks/src/backend.rs

-        match self {
-            Self::Native { fn_type, .. } | Self::ResolveNative { fn_type, .. } => Some(*fn_type),
-            Self::ResolveTrait { .. } => None,
+            deserializer.deserialize_tuple(4, Visitor)


Suggested change

deserializer.deserialize_tuple(4, Visitor)

deserializer.deserialize_tuple(2, Visitor)

…low local-task-based argument resolution

… 4-length one

bgw · 2025-01-24T18:32:12Z

Merge activity

Jan 24, 1:32 PM EST: A user merged this pull request with Graphite.

ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 23, 2025

bgw mentioned this pull request Jan 23, 2025

chore(turbo-tasks): Delete non_local_return support from #[turbo_tasks::function] #75209

Merged

bgw requested review from mischnic and sokra January 23, 2025 05:52

bgw marked this pull request as ready for review January 23, 2025 05:52

bgw changed the base branch from bgw/rm-non-local-return to graphite-base/75214 January 23, 2025 16:38

bgw force-pushed the bgw/rm-backend-argument-resolution branch from ecd31e1 to c069453 Compare January 23, 2025 16:39

bgw force-pushed the graphite-base/75214 branch from 814b026 to a5d24dc Compare January 23, 2025 16:39

bgw changed the base branch from graphite-base/75214 to canary January 23, 2025 16:39

bgw force-pushed the bgw/rm-backend-argument-resolution branch 2 times, most recently from 73d7001 to a629817 Compare January 23, 2025 21:34

bgw mentioned this pull request Jan 23, 2025

refactor(turbo-tasks): Merge dynamic_call/native_call with dynamic_this_call/native_this_call #75253

Merged

bgw force-pushed the bgw/rm-backend-argument-resolution branch from a629817 to 9d83d2a Compare January 24, 2025 04:53

bgw mentioned this pull request Jan 24, 2025

perf(turbo-tasks): Add a 'local' option to #[turbo_tasks::function(..)] #75259

Merged

This was referenced Jan 24, 2025

perf(turbo-tasks): Mark a bunch of stuff as local #75260

Draft

perf(turbo-tasks): Filter out and do not cache unused arguments #75261

Draft

sokra reviewed Jan 24, 2025

View reviewed changes

sokra approved these changes Jan 24, 2025

View reviewed changes

bgw force-pushed the bgw/rm-backend-argument-resolution branch from 9d83d2a to 343ac24 Compare January 24, 2025 16:29

bgw added 3 commits January 24, 2025 09:42

chore(turbo-tasks): Remove argument resolution from backends, only al…

0e35f8c

…low local-task-based argument resolution

Fix lints

696b75d

Only serialize/deserialize a 2-length tuple for CachedTaskType, not a…

0f70ca4

… 4-length one

bgw force-pushed the bgw/rm-backend-argument-resolution branch from 343ac24 to 0f70ca4 Compare January 24, 2025 17:45

bgw merged commit 2aa59ed into canary Jan 24, 2025
131 checks passed

bgw deleted the bgw/rm-backend-argument-resolution branch January 24, 2025 18:32

bgw mentioned this pull request Jan 25, 2025

refactor(turbo-tasks): Port task statistics to the new backend #75303

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(turbo-tasks): Remove argument resolution from backends, only allow local-task-based argument resolution #75214

chore(turbo-tasks): Remove argument resolution from backends, only allow local-task-based argument resolution #75214

bgw commented Jan 23, 2025 •

edited by padmaia

Loading

bgw commented Jan 23, 2025 •

edited

Loading

ijjk commented Jan 23, 2025 •

edited

Loading

ijjk commented Jan 24, 2025 •

edited

Loading

sokra Jan 24, 2025

sokra Jan 24, 2025

sokra Jan 24, 2025

sokra Jan 24, 2025

bgw commented Jan 24, 2025

	deserializer.deserialize_tuple(4, Visitor)
	deserializer.deserialize_tuple(2, Visitor)

chore(turbo-tasks): Remove argument resolution from backends, only allow local-task-based argument resolution #75214

chore(turbo-tasks): Remove argument resolution from backends, only allow local-task-based argument resolution #75214

Conversation

bgw commented Jan 23, 2025 • edited by padmaia Loading

bgw commented Jan 23, 2025 • edited Loading

ijjk commented Jan 23, 2025 • edited Loading

Stats from current PR

ijjk commented Jan 24, 2025 • edited Loading

Tests Passed

sokra Jan 24, 2025

Choose a reason for hiding this comment

sokra Jan 24, 2025

Choose a reason for hiding this comment

sokra Jan 24, 2025

Choose a reason for hiding this comment

sokra Jan 24, 2025

Choose a reason for hiding this comment

bgw commented Jan 24, 2025

Merge activity

bgw commented Jan 23, 2025 •

edited by padmaia

Loading

bgw commented Jan 23, 2025 •

edited

Loading

ijjk commented Jan 23, 2025 •

edited

Loading

ijjk commented Jan 24, 2025 •

edited

Loading