My go at adding (some) Bootstrap 4 support #410
Conversation
Herst
changed the title
|
Classes which appear to be in
|
|
Some (incomplete) lists: Warnings/Errors to be removed
Warnings/Errors in need to be adapted/redone
Warnings/Errors to be added
More specific warnings about BS3 classes being used and what their replacements are
For others see: http://upgrade-bootstrap.bootply.com/ Far away goals
|
|
Updating javascript:(function(){var s=document.createElement("script");s.onload=function(){bootlint.showLintReportForCurrentDocument([]);};s.src="https://rawgit.com/Herst/bootlint/v4/dist/browser/bootlint.js";document.body.appendChild(s)})(); |
|
BTW, collaboration is welcome! |
Herst
changed the title
|
Wow, huge change list! Not sure how to proceed though. Should we keep compatibility with v3? If so should we make a new branch for v4? Or can we have a common codebase? |
|
IMHO, Bootstrap 3 and 4 are too different for the rules (the stuff inside ´src/bootstrap.js´) to be adapted to work with both version which is why in my fork I made it Bootstrap-4-only with a detection for most Bootstrap-3-specific classes (I also threw out everything concerning Bootstrap 2 since I am assuming nobody will switch from v2 to v4). Of course the rest like the other code files inside |
|
Can someone chime in on how to proceed with this? |
|
before that PR, bootlint handle Bootstrap 4 Alpha so we can continue to handle BS3 and BS4 if it's possible |
|
FYI, I will have less time for working on this in the next two months. |
|
Bump! Looks like an awesome work by @Herst that needs to get into official repo. Can someone from original author(s) check here? TIA |
|
Now that the final v4 is out I feel like this should be started anew and done correctly this time, with tests first and PRs for every error/warning to remove/change/add (which then can be separately discussed). I still don't have all the time in the world and this count as a private project so before I begin I would like to assess how much interest there even is for this project and whether there are people willing to give feedback and possibly a helping hand. It would probably be useful to use out of the the list of recent bug reports those which were the result of wrong usage as a basis for a list of BS4-specific warnings/errors to add (e.g. those related to flex stuff). Some suggestions? Also, any update on how to handle Bootstrap 3? I would still prefer maintaining separate versions. |
Also adapted various messages and names of functions.
|
I started a clean new attempt with tests at https://github.com/Herst/bootlint-ng, this will be a proper fork with new name (Bootlint-NG instead of Bootlint), with tests and doing it step-by-step. I am starting with a clean slate with all checks and tests disabled and using Pull Requests for each and every check with gets ported to Bootstrap v4+ (or totally new ones and those being deleted). |
|
@XhmikosR From what I understand there was still no decision on what would happen with Bootstrap 3 support. Since I intent to drop all support for it and only concentrate on the newest Bootstrap version, a fork with a different name makes sense in order to not cause confusion (an alternative would be different major numbers). |
|
@Herst: yeah, initially that was the plan because v3 is still very used. But I guess we could make one last release (maybe after downgrading cheerio since I had some issues there), tag it and move with v4. The point is if you are willing to work on this, you might as well do it in the main repo :) |
|
@XhmikosR What about the wiki pages though? |
|
I don't see the where's the issue. The wiki can be adapted as needed obviously. But anyway, it's clear so far that you want your "own" fork. |
But how to separate it between what concerns Bootstrap 3 and what concerns Bootstrap 4+? Separate the IDs? Have two sections per wiki page?
Not necessarily, but now I started it and I like that it like a clean slate beginning when it comes to issues and pull requests (we could do the same here by simply closing all old issues/PRs like was done in the case of Bootstrap 4). But if you want I could switch back, would be even better if I could then get reviews and feedback from other people, especially those involved in the Bootstrap project. |
|
We can make a parent page which will hold the new v4 rules or something like that. Anyway, like I said, where there's will there's a way. I don't see something causing issues if you want to work on v4 here. |
Well, the rule might stay the same but the description might change (e.g. because of changed classes), therefore my idea with totally separate IDs. But I now that I think of it this might be an overkill, simply a separate section or an explanation what changed with v4+ should suffice. OK, so let's do it? |
|
Perfect, give me a couple of days (due to time difference and weekend) to discuss this with @mdo and make a new GitHub team. If you could also jump on our Slack that would be perfect for quick chats too. |
@Herst FYI This v4 bookmarklet doesn't work anymore due to GitHub blocking. |
|
@rrjanbiah |
|
Updated Bootmarklet for the "next" branch where I am currently doing my work on: javascript:(function(){var s=document.createElement("script");s.onload=function(){bootlint.showLintReportForCurrentDocument([]);};s.src="https://cdn.jsdelivr.net/gh/twbs/bootlint@next/dist/browser/bootlint.js";document.body.appendChild(s)})();See #431 for the current progress when it comes to porting existing checks, including what is still missing and where someone could help me. (/edit: Fixed link. Note: not for excessive traffic.) |
|
You may want to use |
Work in progress, early state ATM.
Note that this is a separate version just for BS4, so this pull request should not actually go into
master(at least until there is a separate branch for BS3).