Added type="button" to <button>s without any type #23866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herst
force-pushed
the
no-button-without-type
branch
2 times, most recently
from
db58f2f to
9932871
Compare
|
a |
|
I think this is a nice change for the reasons mentioned in the bootlint Wiki page. |
Herst
force-pushed
the
no-button-without-type
branch
3 times, most recently
from
e6b4d19 to
73ada66
Compare
XhmikosR
approved these changes
Sep 17, 2017
Herst
force-pushed
the
no-button-without-type
branch
4 times, most recently
from
09cc781 to
69b622f
Compare
Herst
force-pushed
the
no-button-without-type
branch
from
69b622f to
d78b99f
Compare
|
I just noticed that my changes are incompatible with the attribute order as propagated by http://codeguide.co/#html-attribute-order but then there are numerous examples in the docs where this is the case. Should I change it? BTW, I believe there are automated tools which can be used to enforce this. |
Herst
force-pushed
the
no-button-without-type
branch
4 times, most recently
from
e1ecbed to
3486b58
Compare
Herst
force-pushed
the
no-button-without-type
branch
from
3486b58 to
2eb02a5
Compare
mdo
approved these changes
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/twbs/bootlint/wiki/W007
Found as part of my work on bootlint for BS4: twbs/bootlint#410.
I created the following one-liner to do it:
find docs/ -type f -exec perl -pi -e \ 's/(?<=<button )(.*?)(?=>)/@{[(index($1,"type=")!=-1?"$1":"type=\"button\" $1")]}/g' {} +BTW, I am occasionally rebasing my patch branches so you shouldn't need to merge the current HEAD of
v4-devinto my patch.