feat: add autoware_ prefix to topic_state_monitor package #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
14 tasks
sasakisasaki
requested changes
Jan 27, 2025
| @@ -60,7 +60,7 @@ def generate_launch_description(): | |||
|
|
|||
| # Radar topic monitors | |||
| radar_front_center_monitor = ComposableNode( | |||
| package="topic_state_monitor", | |||
| package="autoware_topic_state_monitor", | |||
| plugin="topic_state_monitor::TopicStateMonitorNode", | |||
There was a problem hiding this comment.
Not only package, and also this plugin needs autoware:: namespace. Thus please fix from topic_state_monitor::TopicStateMonitorNode to autoware::topic_state_monitor::TopicStateMonitorNode and other places too.
There was a problem hiding this comment.
fixed in d74f504
|
@mitsudome-r It seems aip_x2_gen2_launch depends on |
Signed-off-by: mitsudome-r <[email protected]>
Signed-off-by: mitsudome-r <[email protected]>
SakodaShintaro
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
$ ros2 launch aip_x2_gen2_launch topic_state_monitor.launch.py
[INFO] [launch]: All log files can be found below /home/shintarosakoda/.ros/log/2025-01-27-12-50-11-378221-dpc2304005-66413
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [component_container-1]: process started with pid [66425]
[component_container-1] [INFO] [1737949811.723246297] [topic_state_monitor.topic_state_monitor_container]: Load Library: /home/shintarosakoda/pilot-auto_main/install/autoware_topic_state_monitor/lib/libautoware_topic_state_monitor.so
[component_container-1] [INFO] [1737949811.736709925] [topic_state_monitor.topic_state_monitor_container]: Found class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[component_container-1] [INFO] [1737949811.736760710] [topic_state_monitor.topic_state_monitor_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[INFO] [launch_ros.actions.load_composable_nodes]: Loaded node '/topic_state_monitor_gnss_pose' in container '/topic_state_monitor/topic_state_monitor_container'
[component_container-1] [INFO] [1737949811.746172607] [topic_state_monitor.topic_state_monitor_container]: Found class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[component_container-1] [INFO] [1737949811.746191113] [topic_state_monitor.topic_state_monitor_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[INFO] [launch_ros.actions.load_composable_nodes]: Loaded node '/topic_state_monitor_imu_data' in container '/topic_state_monitor/topic_state_monitor_container'
[component_container-1] [INFO] [1737949811.751009715] [topic_state_monitor.topic_state_monitor_container]: Found class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[component_container-1] [INFO] [1737949811.751027503] [topic_state_monitor.topic_state_monitor_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[INFO] [launch_ros.actions.load_composable_nodes]: Loaded node '/topic_state_monitor_radar_front_center' in container '/topic_state_monitor/topic_state_monitor_container'
[component_container-1] [INFO] [1737949811.756955967] [topic_state_monitor.topic_state_monitor_container]: Found class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[component_container-1] [INFO] [1737949811.756974771] [topic_state_monitor.topic_state_monitor_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[INFO] [launch_ros.actions.load_composable_nodes]: Loaded node '/topic_state_monitor_radar_front_left' in container '/topic_state_monitor/topic_state_monitor_container'
[component_container-1] [INFO] [1737949811.760449256] [topic_state_monitor.topic_state_monitor_container]: Found class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[component_container-1] [INFO] [1737949811.760467140] [topic_state_monitor.topic_state_monitor_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[INFO] [launch_ros.actions.load_composable_nodes]: Loaded node '/topic_state_monitor_radar_front_right' in container '/topic_state_monitor/topic_state_monitor_container'
[component_container-1] [INFO] [1737949811.764083055] [topic_state_monitor.topic_state_monitor_container]: Found class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[component_container-1] [INFO] [1737949811.764100971] [topic_state_monitor.topic_state_monitor_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[INFO] [launch_ros.actions.load_composable_nodes]: Loaded node '/topic_state_monitor_radar_rear_center' in container '/topic_state_monitor/topic_state_monitor_container'
[component_container-1] [INFO] [1737949811.767376412] [topic_state_monitor.topic_state_monitor_container]: Found class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[component_container-1] [INFO] [1737949811.767394513] [topic_state_monitor.topic_state_monitor_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[INFO] [launch_ros.actions.load_composable_nodes]: Loaded node '/topic_state_monitor_radar_rear_left' in container '/topic_state_monitor/topic_state_monitor_container'
[component_container-1] [INFO] [1737949811.770647729] [topic_state_monitor.topic_state_monitor_container]: Found class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[component_container-1] [INFO] [1737949811.770661393] [topic_state_monitor.topic_state_monitor_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<autoware::topic_state_monitor::TopicStateMonitorNode>
[INFO] [launch_ros.actions.load_composable_nodes]: Loaded node '/topic_state_monitor_radar_rear_right' in container '/topic_state_monitor/topic_state_monitor_container'
[component_container-1] [INFO] [1737949811.844541355] [topic_state_monitor_gnss_pose]: /sensing/gnss/pose has not received. Set ERROR in diagnostics.LGTM
sasakisasaki
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Quick Comment
👍
Reason for Approval
As this PR's description says, this is the PR for package name prefixing. The renamed one in this PR is working as @SakodaShintaro san tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds autoware_ prefix to topic_state_monitor package.
For the details, please refer to autowarefoundation/autoware.universe#9961.
How was this PR tested?
ros2 launch aip_x2_gen2_launch topic_state_monitor.launch.py
Notes for reviewers
This must be merged with autowarefoundation/autoware.universe#9961