Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoware_ prefix to topic_state_monitor package #375

Merged
merged 4 commits into from
Jan 27, 2025
Merged

feat: add autoware_ prefix to topic_state_monitor package #375

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05a75b3
feat: add autoware_ prefix to topic_state_monitor package
mitsudome-r Jan 24, 2025
d74f504
fix: add autoware namespace to plugin
mitsudome-r Jan 27, 2025
c54bd0f
fix: add autoware_topic_state_monitor to package dependency
mitsudome-r Jan 27, 2025
6a4fa18
Merge branch 'tier4/universe' into rename-topic-state-monitor
SakodaShintaro Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aip_x1_launch/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@
<exec_depend>autoware_imu_corrector</exec_depend>
<exec_depend>autoware_occupancy_grid_map_outlier_filter</exec_depend>
<exec_depend>autoware_pointcloud_preprocessor</exec_depend>
<exec_depend>autoware_topic_state_monitor</exec_depend>
<exec_depend>autoware_vehicle_velocity_converter</exec_depend>
<exec_depend>common_sensor_launch</exec_depend>
<exec_depend>individual_params</exec_depend>
<exec_depend>rclcpp_components</exec_depend>
<exec_depend>ros2_socketcan</exec_depend>
<exec_depend>tamagawa_imu_driver</exec_depend>
<exec_depend>topic_state_monitor</exec_depend>

<test_depend>ament_lint_auto</test_depend>
<test_depend>autoware_lint_common</test_depend>
Expand Down
16 changes: 8 additions & 8 deletions aip_x2_gen2_launch/launch/topic_state_monitor.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
def generate_launch_description():
# GNSS topic monitor
gnss_topic_monitor = ComposableNode(
package="topic_state_monitor",
package="autoware_topic_state_monitor",
plugin="topic_state_monitor::TopicStateMonitorNode",
name="topic_state_monitor_gnss_pose",
parameters=[
Expand All @@ -40,7 +40,7 @@ def generate_launch_description():

# IMU topic monitor
imu_topic_monitor = ComposableNode(
package="topic_state_monitor",
package="autoware_topic_state_monitor",
plugin="topic_state_monitor::TopicStateMonitorNode",
name="topic_state_monitor_imu_data",
parameters=[
Expand All @@ -60,7 +60,7 @@ def generate_launch_description():

# Radar topic monitors
radar_front_center_monitor = ComposableNode(
package="topic_state_monitor",
package="autoware_topic_state_monitor",
plugin="topic_state_monitor::TopicStateMonitorNode",
Copy link

@sasakisasaki sasakisasaki Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only package, and also this plugin needs autoware:: namespace. Thus please fix from topic_state_monitor::TopicStateMonitorNode to autoware::topic_state_monitor::TopicStateMonitorNode and other places too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in d74f504

name="topic_state_monitor_radar_front_center",
parameters=[
Expand All @@ -79,7 +79,7 @@ def generate_launch_description():
)

radar_front_left_monitor = ComposableNode(
package="topic_state_monitor",
package="autoware_topic_state_monitor",
plugin="topic_state_monitor::TopicStateMonitorNode",
name="topic_state_monitor_radar_front_left",
parameters=[
Expand All @@ -98,7 +98,7 @@ def generate_launch_description():
)

radar_front_right_monitor = ComposableNode(
package="topic_state_monitor",
package="autoware_topic_state_monitor",
plugin="topic_state_monitor::TopicStateMonitorNode",
name="topic_state_monitor_radar_front_right",
parameters=[
Expand All @@ -117,7 +117,7 @@ def generate_launch_description():
)

radar_rear_center_monitor = ComposableNode(
package="topic_state_monitor",
package="autoware_topic_state_monitor",
plugin="topic_state_monitor::TopicStateMonitorNode",
name="topic_state_monitor_radar_rear_center",
parameters=[
Expand All @@ -136,7 +136,7 @@ def generate_launch_description():
)

radar_rear_left_monitor = ComposableNode(
package="topic_state_monitor",
package="autoware_topic_state_monitor",
plugin="topic_state_monitor::TopicStateMonitorNode",
name="topic_state_monitor_radar_rear_left",
parameters=[
Expand All @@ -155,7 +155,7 @@ def generate_launch_description():
)

radar_rear_right_monitor = ComposableNode(
package="topic_state_monitor",
package="autoware_topic_state_monitor",
plugin="topic_state_monitor::TopicStateMonitorNode",
name="topic_state_monitor_radar_rear_right",
parameters=[
Expand Down
Loading