Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(starknet_os): move hint implementation functions into separate folder #3708

Merged
merged 1 commit into from
Jan 29, 2025
Merged

refactor(starknet_os): move hint implementation functions into separate folder #3708

merged 1 commit into from
Jan 29, 2025

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@dorimedini-starkware dorimedini-starkware mentioned this pull request Jan 27, 2025
Merged
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review January 27, 2025 11:18
This was referenced Jan 27, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Jan 27, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dorimedini-starkware dorimedini-starkware self-assigned this Jan 27, 2025
This was referenced Jan 27, 2025
Merged
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-test_starknet_os_test_hint_strings_are_unique branch from 9c6a082 to a466961 Compare January 27, 2025 19:37
@dorimedini-starkware dorimedini-starkware force-pushed the 01-27-refactor_starknet_os_move_hint_implementation_functions_into_separate_folder branch from 077dcac to 2930e13 Compare January 27, 2025 19:37
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-test_starknet_os_test_hint_strings_are_unique branch from a466961 to 22f9b39 Compare January 28, 2025 10:07
@dorimedini-starkware dorimedini-starkware force-pushed the 01-27-refactor_starknet_os_move_hint_implementation_functions_into_separate_folder branch from 2930e13 to 2a1dbb5 Compare January 28, 2025 10:07
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-test_starknet_os_test_hint_strings_are_unique branch from 22f9b39 to 7c3c4a9 Compare January 28, 2025 11:04
@dorimedini-starkware dorimedini-starkware force-pushed the 01-27-refactor_starknet_os_move_hint_implementation_functions_into_separate_folder branch from b5890c9 to 32997de Compare January 28, 2025 14:47
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-test_starknet_os_test_hint_strings_are_unique branch from a2bbe01 to 16892db Compare January 28, 2025 15:29
@dorimedini-starkware dorimedini-starkware force-pushed the 01-27-refactor_starknet_os_move_hint_implementation_functions_into_separate_folder branch from 32997de to 0b9dbaa Compare January 28, 2025 15:29
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-test_starknet_os_test_hint_strings_are_unique branch from 16892db to 8afa869 Compare January 28, 2025 15:33
@dorimedini-starkware dorimedini-starkware force-pushed the 01-27-refactor_starknet_os_move_hint_implementation_functions_into_separate_folder branch from 0b9dbaa to 17ca835 Compare January 28, 2025 15:34
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-test_starknet_os_test_hint_strings_are_unique branch from 8afa869 to 27c728c Compare January 28, 2025 16:36
@dorimedini-starkware dorimedini-starkware force-pushed the 01-27-refactor_starknet_os_move_hint_implementation_functions_into_separate_folder branch from 17ca835 to 14b34d3 Compare January 28, 2025 16:37
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-test_starknet_os_test_hint_strings_are_unique branch from 27c728c to bb5523e Compare January 28, 2025 20:56
@dorimedini-starkware dorimedini-starkware force-pushed the 01-27-refactor_starknet_os_move_hint_implementation_functions_into_separate_folder branch from 14b34d3 to caa09ea Compare January 28, 2025 20:56
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-test_starknet_os_test_hint_strings_are_unique branch from bb5523e to 3972cb7 Compare January 29, 2025 07:43
@dorimedini-starkware dorimedini-starkware force-pushed the 01-27-refactor_starknet_os_move_hint_implementation_functions_into_separate_folder branch from caa09ea to 3f9f7bf Compare January 29, 2025 07:43
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-test_starknet_os_test_hint_strings_are_unique branch from 3972cb7 to 82642cf Compare January 29, 2025 08:13
@dorimedini-starkware dorimedini-starkware force-pushed the 01-27-refactor_starknet_os_move_hint_implementation_functions_into_separate_folder branch from 3f9f7bf to b4fac15 Compare January 29, 2025 08:13
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-test_starknet_os_test_hint_strings_are_unique branch from 82642cf to 1ad40d0 Compare January 29, 2025 09:23
@dorimedini-starkware dorimedini-starkware force-pushed the 01-27-refactor_starknet_os_move_hint_implementation_functions_into_separate_folder branch from b4fac15 to 11300f7 Compare January 29, 2025 09:23
This was referenced Jan 29, 2025
Merged
Merged
Yoni-Starkware
Yoni-Starkware approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 20 of 21 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware mentioned this pull request Jan 29, 2025
Closed
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-test_starknet_os_test_hint_strings_are_unique branch from 1ad40d0 to 88f5536 Compare January 29, 2025 13:59
@dorimedini-starkware dorimedini-starkware force-pushed the 01-27-refactor_starknet_os_move_hint_implementation_functions_into_separate_folder branch from 11300f7 to 78cfb5c Compare January 29, 2025 13:59
@dorimedini-starkware dorimedini-starkware mentioned this pull request Jan 29, 2025
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-test_starknet_os_test_hint_strings_are_unique branch from 88f5536 to ccda0fc Compare January 29, 2025 15:01
@dorimedini-starkware dorimedini-starkware force-pushed the 01-27-refactor_starknet_os_move_hint_implementation_functions_into_separate_folder branch from 78cfb5c to eed3b12 Compare January 29, 2025 15:02
@dorimedini-starkware dorimedini-starkware changed the base branch from 01-26-test_starknet_os_test_hint_strings_are_unique to main January 29, 2025 15:49
@dorimedini-starkware dorimedini-starkware force-pushed the 01-27-refactor_starknet_os_move_hint_implementation_functions_into_separate_folder branch from eed3b12 to 7dc9736 Compare January 29, 2025 15:50
@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 4b60bf8 Jan 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amosStarkware amosStarkware amosStarkware approved these changes

@Yoni-Starkware Yoni-Starkware Yoni-Starkware approved these changes

Assignees

@dorimedini-starkware dorimedini-starkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dorimedini-starkware @reviewable-StarkWare @Yoni-Starkware @amosStarkware