Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(starknet_os): integrate secp hints #3696

Merged
merged 1 commit into from
Jan 29, 2025
Merged

feat(starknet_os): integrate secp hints #3696

merged 1 commit into from
Jan 29, 2025

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

This was referenced Jan 26, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Jan 26, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 26, 2025
Merged
Merged
Merged
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review January 26, 2025 15:58
This was referenced Jan 26, 2025
Merged
Merged
@dorimedini-starkware dorimedini-starkware self-assigned this Jan 26, 2025
This was referenced Jan 27, 2025
Merged
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_patricia_hints branch from 305793a to 74649bc Compare January 27, 2025 19:37
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_secp_hints branch from bffbd80 to 17211f6 Compare January 27, 2025 19:37
amosStarkware
amosStarkware approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_patricia_hints branch from 74649bc to 80650ee Compare January 28, 2025 10:06
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_secp_hints branch from 17211f6 to 55d4a18 Compare January 28, 2025 10:06
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_secp_hints branch from 36a8d7a to a5a7f00 Compare January 28, 2025 11:25
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_patricia_hints branch from a832892 to 447e70f Compare January 28, 2025 11:46
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_secp_hints branch from a5a7f00 to cc77447 Compare January 28, 2025 11:46
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_patricia_hints branch from 447e70f to 03551f6 Compare January 28, 2025 12:30
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_secp_hints branch from cc77447 to 2eebf72 Compare January 28, 2025 12:30
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_patricia_hints branch from 03551f6 to e932973 Compare January 28, 2025 12:57
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_secp_hints branch from 2eebf72 to cc43216 Compare January 28, 2025 12:57
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_patricia_hints branch from e932973 to 69c3de7 Compare January 28, 2025 13:19
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_secp_hints branch from cc43216 to e6f9740 Compare January 28, 2025 13:19
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_patricia_hints branch from 69c3de7 to 651daf9 Compare January 28, 2025 14:10
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_secp_hints branch from e6f9740 to c286f93 Compare January 28, 2025 14:10
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_patricia_hints branch from 651daf9 to 448dd6b Compare January 28, 2025 14:46
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_secp_hints branch from c286f93 to 4b090e9 Compare January 28, 2025 14:46
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_patricia_hints branch from 448dd6b to b59bede Compare January 28, 2025 15:28
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_secp_hints branch from 4b090e9 to 65fed12 Compare January 28, 2025 15:28
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_patricia_hints branch from b59bede to 1dc9583 Compare January 28, 2025 16:36
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_secp_hints branch from 65fed12 to f340b22 Compare January 28, 2025 16:36
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_patricia_hints branch from 1dc9583 to 5dd99d8 Compare January 28, 2025 20:55
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_secp_hints branch from f340b22 to b1fe9a9 Compare January 28, 2025 20:55
@dorimedini-starkware dorimedini-starkware changed the base branch from 01-26-feat_starknet_os_integrate_patricia_hints to main January 28, 2025 21:18
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 28, 2025

Merge activity

  • Jan 28, 4:27 PM EST: Graphite disabled "merge when ready" on this PR due to: We hit a GitHub rate limit while trying to merge. If you are attempting to merge a large stack, breaking it up into smaller chunks may help..

@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_secp_hints branch from b1fe9a9 to 4ce7fda Compare January 29, 2025 07:43
@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 358f1f7 Jan 29, 2025
9 checks passed
This was referenced Jan 29, 2025
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amosStarkware amosStarkware amosStarkware approved these changes

@Yoni-Starkware Yoni-Starkware Awaiting requested review from Yoni-Starkware

Assignees

@dorimedini-starkware dorimedini-starkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dorimedini-starkware @reviewable-StarkWare @amosStarkware