Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_os): integrate syscalls hints #3698

Merged

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Jan 26, 2025

Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_state_hints branch from 700918b to d9f9a6c Compare January 28, 2025 10:07
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_syscalls_hints branch from c3307ce to 68ea105 Compare January 28, 2025 10:07
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_state_hints branch from 8e206d8 to 7147fff Compare January 28, 2025 14:10
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_syscalls_hints branch from b043529 to 0c9f7f5 Compare January 28, 2025 14:10
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_state_hints branch from 7147fff to 465e33b Compare January 28, 2025 14:46
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_syscalls_hints branch from 0c9f7f5 to e4f05fe Compare January 28, 2025 14:46
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_state_hints branch from 465e33b to 605e851 Compare January 28, 2025 15:28
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_syscalls_hints branch from e4f05fe to 8914f56 Compare January 28, 2025 15:28
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_state_hints branch from 605e851 to b8604e8 Compare January 28, 2025 16:36
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_syscalls_hints branch from 8914f56 to 8b3f4a4 Compare January 28, 2025 16:36
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_state_hints branch from b8604e8 to 550b521 Compare January 28, 2025 20:55
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_syscalls_hints branch from 8b3f4a4 to 3fbf9de Compare January 28, 2025 20:55
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_state_hints branch from 550b521 to b443a60 Compare January 29, 2025 07:43
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_syscalls_hints branch from 3fbf9de to ae099e1 Compare January 29, 2025 07:43
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_state_hints branch from b443a60 to a348d3d Compare January 29, 2025 08:12
@dorimedini-starkware dorimedini-starkware force-pushed the 01-26-feat_starknet_os_integrate_syscalls_hints branch from ae099e1 to 9691a31 Compare January 29, 2025 08:12
@dorimedini-starkware dorimedini-starkware changed the base branch from 01-26-feat_starknet_os_integrate_state_hints to main January 29, 2025 08:30
Copy link

graphite-app bot commented Jan 29, 2025

Merge activity

  • Jan 29, 3:43 AM EST: Graphite disabled "merge when ready" on this PR due to: We hit a GitHub rate limit while trying to merge. If you are attempting to merge a large stack, breaking it up into smaller chunks may help..

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/starknet_os/src/hints/syscalls.rs line 1 at r2 (raw file):

use std::collections::HashMap;

Please split the hints to files as follows:
deprecated_syscalls (almost everything here)
os_logger (enter/exit funcs)

And set_syscall_ptr should be in execute_entry_point

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)


crates/starknet_os/src/hints/syscalls.rs line 1 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Please split the hints to files as follows:
deprecated_syscalls (almost everything here)
os_logger (enter/exit funcs)

And set_syscall_ptr should be in execute_entry_point

Done, separate PR (PTAL)

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit bfeeea1 Jan 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants