-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starknet_os): integrate syscalls hints #3698
feat(starknet_os): integrate syscalls hints #3698
Conversation
f57efd3
to
700918b
Compare
d9a8118
to
c3307ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
700918b
to
d9f9a6c
Compare
c3307ce
to
68ea105
Compare
8e206d8
to
7147fff
Compare
b043529
to
0c9f7f5
Compare
7147fff
to
465e33b
Compare
0c9f7f5
to
e4f05fe
Compare
465e33b
to
605e851
Compare
e4f05fe
to
8914f56
Compare
605e851
to
b8604e8
Compare
8914f56
to
8b3f4a4
Compare
b8604e8
to
550b521
Compare
8b3f4a4
to
3fbf9de
Compare
550b521
to
b443a60
Compare
3fbf9de
to
ae099e1
Compare
b443a60
to
a348d3d
Compare
ae099e1
to
9691a31
Compare
Merge activity
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/starknet_os/src/hints/syscalls.rs
line 1 at r2 (raw file):
use std::collections::HashMap;
Please split the hints to files as follows:
deprecated_syscalls (almost everything here)
os_logger (enter/exit funcs)
And set_syscall_ptr
should be in execute_entry_point
9691a31
to
e670781
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)
crates/starknet_os/src/hints/syscalls.rs
line 1 at r2 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Please split the hints to files as follows:
deprecated_syscalls (almost everything here)
os_logger (enter/exit funcs)And
set_syscall_ptr
should be in execute_entry_point
Done, separate PR (PTAL)
e670781
to
291087b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
No description provided.