fix(blockifier): get alias from last state diff

[yoavGrs]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-25T11:11:43Z
• Started at 2024-12-25T13:10:00Z
• Started at 2024-12-25T13:53:57Z
• Started at 2024-12-25T14:03:14Z
• Started at 2024-12-29T07:38:45Z
• Started at 2024-12-29T13:10:55Z
• Started at 2024-12-29T14:15:37Z

[yoavGrs]

• feat(blockifier): return compressed state diff at finalizing #2767
• fix(blockifier): get alias from last state diff #2946 👈 (View in Graphite)
• main-v0.13.4

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Yoni-Starkware]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @yoavGrs)

---

crates/blockifier/src/state/stateful_compression.rs line 183 at r1 (raw file):

struct AliasCompressor<'a, S: StateReader> {
    state: &'a S,
    alias_contract_address: ContractAddress,

Why is this needed? use the constant

Code quote:

    alias_contract_address: ContractAddress,

---

crates/blockifier/src/state/stateful_compression.rs line 194 at r1 (raw file):

            new_aliases: state_diff
                .storage
                .iter()

Since you need to iterate the entire diff again, how about a more straightforward suggestion (that would be compatible with the execution):

In state_diff_with_alias_allocation:

• Compute state_diff_without_aliases
• Let the AliasUpdater insert the new aliases directly to the state.
• Compute the state diff again.

Now the AliasCompressor has all the info in state.

Code quote:

                .storage
                .iter()

[Yoni-Starkware]

Reviewed 1 of 3 files at r2.
Reviewable status: 1 of 3 files reviewed, 4 unresolved discussions (waiting on @dorimedini-starkware and @yoavGrs)

---

crates/blockifier/src/state/stateful_compression.rs line 84 at r2 (raw file):

/// Updates the alias contract with the new keys.
struct AliasUpdater<'a, S: StateReader> {
    state: &'a mut CachedState<S>,

Try this

Suggestion:

struct AliasUpdater<'a, S: State> {
    state: &'a mut S,

---

crates/blockifier/src/blockifier/transaction_executor.rs line 171 at r2 (raw file):

        log::debug!("Final block weights: {:?}.", self.bouncer.get_accumulated_weights());
        let mut block_state = self.block_state.take().expect(BLOCK_STATE_ACCESS_ERR);

Why not?

Suggestion:

self.block_state.as_mut().expect(BLOCK_STATE_ACCESS_ERR);

[Yoni-Starkware]

Reviewed 1 of 3 files at r2.
Reviewable status: 2 of 3 files reviewed, 4 unresolved discussions (waiting on @dorimedini-starkware and @yoavGrs)

[yoavGrs]

Reviewable status: 1 of 3 files reviewed, 4 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 171 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Why not?

Done.

---

crates/blockifier/src/state/stateful_compression.rs line 183 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Why is this needed? use the constant

I removed the constant when I saw it in the versioned_constants

---

crates/blockifier/src/state/stateful_compression.rs line 194 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Since you need to iterate the entire diff again, how about a more straightforward suggestion (that would be compatible with the execution):

In state_diff_with_alias_allocation:

• Compute state_diff_without_aliases
• Let the AliasUpdater insert the new aliases directly to the state.
• Compute the state diff again.

Now the AliasCompressor has all the info in state.

Done.

---

crates/blockifier/src/state/stateful_compression.rs line 84 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Try this

Done.

[Yoni-Starkware]

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[yoavGrs]

Merge activity

• Dec 26, 7:50 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
• Dec 29, 4:40 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 29, 4:40 AM EST: Graphite couldn't add this PR to the GitHub merge queue because it failed for an unknown reason.

[Yoni-Starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

[dorimedini-starkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

---

crates/blockifier/src/state/stateful_compression.rs line 114 at r4 (raw file):

                Some(alias) => alias,
                None => INITIAL_AVAILABLE_ALIAS,
            };

non-blocking; but this should be equivalent

Suggestion:

            let alias_to_allocate = self.next_free_alias.unwrap_or(INITIAL_AVAILABLE_ALIAS);

[yoavGrs]

Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

---

crates/blockifier/src/state/stateful_compression.rs line 114 at r4 (raw file):

Previously, dorimedini-starkware wrote…

non-blocking; but this should be equivalent

Done.

[Yoni-Starkware]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)