Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blockifier): return compressed state diff at finalizing #2767

Merged
merged 1 commit into from
Dec 30, 2024
Merged

feat(blockifier): return compressed state diff at finalizing #2767

merged 1 commit into from
Dec 30, 2024

Conversation

yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented Dec 18, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

This was referenced Dec 18, 2024
Merged
Merged
@yoavGrs Graphite App
Copy link
Contributor Author

yoavGrs commented Dec 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Artifacts upload workflows:

@yoavGrs yoavGrs marked this pull request as ready for review December 18, 2024 15:10
@yoavGrs yoavGrs force-pushed the yoav/compression/compress_state_diff branch 2 times, most recently from 86efe96 to 3a1c429 Compare December 19, 2024 15:12
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from f2d61ca to a33587d Compare December 19, 2024 15:13
@yoavGrs yoavGrs force-pushed the yoav/compression/compress_state_diff branch 2 times, most recently from 1644fd5 to f7862bb Compare December 22, 2024 09:04
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from a33587d to 963bf0d Compare December 22, 2024 11:52
@yoavGrs yoavGrs force-pushed the yoav/compression/compress_state_diff branch from f7862bb to edbf88b Compare December 23, 2024 08:23
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from 963bf0d to 7fcec04 Compare December 23, 2024 08:23
@yoavGrs yoavGrs force-pushed the yoav/compression/compress_state_diff branch from edbf88b to 814abff Compare December 23, 2024 09:07
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from 7fcec04 to a19d6fb Compare December 23, 2024 09:07
@yoavGrs yoavGrs force-pushed the yoav/compression/compress_state_diff branch from 814abff to f46dab6 Compare December 23, 2024 09:30
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from a19d6fb to 6478852 Compare December 23, 2024 09:30
@yoavGrs yoavGrs force-pushed the yoav/compression/compress_state_diff branch from f46dab6 to e25383e Compare December 23, 2024 12:57
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from 6478852 to f2d921a Compare December 23, 2024 12:57
@yoavGrs yoavGrs force-pushed the yoav/compression/compress_state_diff branch 2 times, most recently from 5433ec4 to 4f92b53 Compare December 23, 2024 13:29
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from f2d921a to d999408 Compare December 23, 2024 13:29
@yoavGrs yoavGrs force-pushed the yoav/compression/compress_state_diff branch 2 times, most recently from e6f35c8 to 199ab60 Compare December 23, 2024 14:33
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from d999408 to 66cc1b5 Compare December 23, 2024 14:33
@yoavGrs yoavGrs changed the base branch from yoav/compression/compress_state_diff to graphite-base/2767 December 23, 2024 14:53
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from 66cc1b5 to f817b41 Compare December 23, 2024 14:54
@yoavGrs yoavGrs changed the base branch from graphite-base/2767 to main December 23, 2024 14:54
Yoni-Starkware
Yoni-Starkware approved these changes Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 8 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

@yoavGrs yoavGrs force-pushed the yoav/compression/look_at_alias_contract branch from 5937694 to 8f1025d Compare December 25, 2024 13:10
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from b069c85 to e5a47a6 Compare December 25, 2024 13:10
Yoni-Starkware
Yoni-Starkware approved these changes Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

@yoavGrs yoavGrs force-pushed the yoav/compression/look_at_alias_contract branch from 8f1025d to 5956f90 Compare December 25, 2024 13:53
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from e5a47a6 to 81a85e5 Compare December 25, 2024 13:54
@yoavGrs yoavGrs force-pushed the yoav/compression/look_at_alias_contract branch from 5956f90 to 3b6e5a0 Compare December 25, 2024 14:03
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from 81a85e5 to e8ab116 Compare December 25, 2024 14:03
Yoni-Starkware
Yoni-Starkware approved these changes Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

@yoavGrs yoavGrs removed the request for review from dorimedini-starkware December 25, 2024 15:05
@yoavGrs yoavGrs force-pushed the yoav/compression/look_at_alias_contract branch from 3b6e5a0 to 9a0991c Compare December 29, 2024 07:38
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch 2 times, most recently from 29d4f0c to 7c09988 Compare December 29, 2024 07:49
Yoni-Starkware
Yoni-Starkware requested changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yoavGrs)

crates/native_blockifier/src/py_block_executor.rs line 260 at r5 (raw file):

    }

    /// Returns the state diff, a list of contract class hash and the block weights.

Suggestion:

ff, the stateful-compressed state diff and the block weights.

@yoavGrs yoavGrs changed the base branch from yoav/compression/look_at_alias_contract to graphite-base/2767 December 29, 2024 09:40
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from 7c09988 to a3a59b9 Compare December 29, 2024 12:43
yoavGrs
yoavGrs commented Dec 29, 2024
View reviewed changes
Copy link
Contributor Author

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Yoni-Starkware)

crates/native_blockifier/src/py_block_executor.rs line 260 at r5 (raw file):

    }

    /// Returns the state diff, a list of contract class hash and the block weights.

Done.

@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from a3a59b9 to 40ac927 Compare December 29, 2024 13:11
Yoni-Starkware
Yoni-Starkware approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)

@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from 40ac927 to 5351b54 Compare December 29, 2024 14:15
Yoni-Starkware
Yoni-Starkware approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

dorimedini-starkware
dorimedini-starkware approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs changed the base branch from graphite-base/2767 to main-v0.13.4 December 29, 2024 15:17
@yoavGrs yoavGrs force-pushed the yoav/compression/return_two_state_diffs branch from 5351b54 to a83e511 Compare December 29, 2024 15:18
@yoavGrs yoavGrs merged commit 27b39c0 into main-v0.13.4 Dec 30, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yoni-Starkware Yoni-Starkware Yoni-Starkware approved these changes

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

Assignees

@yoavGrs yoavGrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoavGrs @reviewable-StarkWare @dorimedini-starkware @Yoni-Starkware