chore(cairo_native): make the starknet-native-compile crate a part of the workspace

[avi-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-30T13:05:23Z
• Started at 2024-12-30T13:36:43Z
• Started at 2025-01-06T07:32:45Z
• Started at 2025-01-06T08:08:48Z
• Started at 2025-01-06T11:40:44Z
• Started at 2025-01-06T13:29:51Z

[noaov1]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avi-starkware, @meship-starkware, and @Yoni-Starkware)

---

Cargo.toml line 60 at r1 (raw file):

]

exclude = ["crates/bin/starknet-native-compile"]

What does it mean?

Code quote:

exclude = ["crates/bin/starknet-native-compile"]

---

crates/bin/starknet-native-compile/src/utils.rs line 1 at r1 (raw file):

#[cfg(feature = "cairo_native")]

Is it necessary, considering the file already has the feature flag above its declaration? 🤔

Code quote:

#[cfg(feature = "cairo_native")]

[noaov1]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @avi-starkware, @meship-starkware, and @Yoni-Starkware)

---

crates/bin/starknet-native-compile/Cargo.toml line 11 at r1 (raw file):

[features]
cairo_native = [

How do you make sure that the starknet_sierra_compile crate uses this crate with the cairo_native feature flag?

Code quote:

cairo_native = [

[github-actions]

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.320 ms 30.358 ms 30.397 ms]
change: [+1.8628% +2.0649% +2.2621%] (p = 0.00 < 0.05)
Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mild

[avi-starkware]

crates/bin/starknet-native-compile/Cargo.toml line 11 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

How do you make sure that the starknet_sierra_compile crate uses this crate with the cairo_native feature flag?

starknet_sierra_compile does not depend on this crate directly it builds it via cargo install, so I just add the feature as an argument in cargo install

[avi-starkware]

Cargo.toml line 60 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

What does it mean?

It just means that the crate is not part of the workspace and will not be compiled automatically when running cargo build from the root dir. I did this to avoid having the entire workspace depend on cairo_native.

[github-actions]

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.362 ms 30.405 ms 30.452 ms]
change: [+2.0768% +2.4169% +2.7186%] (p = 0.00 < 0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe

[meship-starkware]

Reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @avi-starkware, @noaov1, and @Yoni-Starkware)

[noaov1]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @Yoni-Starkware)

[avi-starkware]

crates/bin/starknet-native-compile/src/utils.rs line 1 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Is it necessary, considering the file already has the feature flag above its declaration? 🤔

If we don't put this over each import that is only used with the feature flag, we will get an unused_import clippy error

[noaov1]

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)