Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display the pinning policy options same as block_cache/metadata_cache #805

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Display the pinning policy options same as block_cache/metadata_cache #805

merged 2 commits into from
Feb 20, 2024

Conversation

udi-speedb
Copy link
Contributor

No description provided.

@udi-speedb udi-speedb requested a review from Yuval-Ariel January 7, 2024 11:31
@udi-speedb udi-speedb self-assigned this Jan 7, 2024
@udi-speedb udi-speedb linked an issue Jan 7, 2024 that may be closed by this pull request
LOG Consistency:Display the pinning policy options same as block cache options / metadata cache options #804
Closed
@udi-speedb udi-speedb force-pushed the 804-log-consistencydisplay-the-pinning-policy-options-same-as-block-cache-options-metadata-cache-options branch from 06d9deb to d13bb15 Compare January 7, 2024 11:31
@udi-speedb
Copy link
Contributor Author

@Yuval-Ariel - This is a sample of how the log file looks after the change:

  metadata_cache_options:
    top_level_index_pinning: 0
    partition_pinning: 0
    unpartitioned_pinning: 0
  index_type: 0
  data_block_index_type: 0
  index_shortening: 1
  data_block_hash_table_util_ratio: 0.750000
  checksum: 4
  no_block_cache: 0
  block_cache: 0x55fdd6eaa3d0
  block_cache_name: LRUCache
  block_cache_options:
    capacity : 33554432
    num_shard_bits : 6
    strict_capacity_limit : 0
    memory_allocator : None
    high_pri_pool_ratio: 0.000
    low_pri_pool_ratio: 0.000
  persistent_cache: (nil)
  pinning_policy_name: speedb_scoped_pinning_policy
  pinning_policy_options:
    capacity: 26843545
    last_level_with_data_percent: 10
    mid_percent: 70
  block_size: 4096

Yuval-Ariel
Yuval-Ariel previously approved these changes Jan 10, 2024
View reviewed changes
@Yuval-Ariel
Merge branch 'main' into 804-log-consistencydisplay-the-pinning-polic…
a8cdaf9 
…y-options-same-as-block-cache-options-metadata-cache-options
@Yuval-Ariel Yuval-Ariel self-requested a review February 20, 2024 09:20
@Yuval-Ariel Yuval-Ariel merged commit 4d3c988 into main Feb 20, 2024
22 checks passed
@Yuval-Ariel Yuval-Ariel deleted the 804-log-consistencydisplay-the-pinning-policy-options-same-as-block-cache-options-metadata-cache-options branch February 20, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuval-Ariel Yuval-Ariel Yuval-Ariel approved these changes

Assignees

@udi-speedb udi-speedb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LOG Consistency:Display the pinning policy options same as block cache options / metadata cache options
2 participants
@udi-speedb @Yuval-Ariel