Skip to content

Commit

Permalink
LOG: Align pinning policy options with block_cache/metadata_cache opt…
Browse files Browse the repository at this point in the history
…ions (#805)
  • Loading branch information
udi-speedb authored Feb 20, 2024
1 parent 2bb49eb commit 4d3c988
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 2 additions & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
### Enhancements

### Bug Fixes
* LOG Consistency:Display the pinning policy options same as block cache options / metadata cache options (#804).

### Miscellaneous
* WriteController logging: Remove redundant reports when WC is not shared between dbs
Expand Down Expand Up @@ -44,6 +45,7 @@ RocksDB has a value of 10 by default and we've added the option to randomize the
* Proactive Flushes: Have the initiator return a correct answer when it was requested to initate a flush (#812).
* stress test: Adding a trace file by default in PR https://github.com/speedb-io/speedb/pull/797 has revealed some incompatibilities between the trace file and several configurations (more details in https://github.com/speedb-io/speedb/issues/813). Keep the trace file and remove the IsDone assertion.


### Miscellaneous
* Remove leftover references to ROCKSDB_LITE (#755).
* Options: Set compaction_readahead_size default to 0. The current default of 2Mb is not optimal for most of our use cases. Having a value of 0 means that the FS will use its default size for prefetching (true only with https://github.com/speedb-io/speedb/pull/788).
Expand Down
7 changes: 3 additions & 4 deletions plugin/speedb/pinning_policy/scoped_pinning_policy.cc
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,16 @@ std::string ScopedPinningPolicy::GetPrintableOptions() const {
const int kBufferSize = 200;
char buffer[kBufferSize];

snprintf(buffer, kBufferSize,
" pinning_policy.capacity: %" ROCKSDB_PRIszt "\n",
snprintf(buffer, kBufferSize, " capacity: %" ROCKSDB_PRIszt "\n",
options_.capacity);
ret.append(buffer);

snprintf(buffer, kBufferSize,
" pinning_policy.last_level_with_data_percent: %" PRIu32 "\n",
" last_level_with_data_percent: %" PRIu32 "\n",
options_.last_level_with_data_percent);
ret.append(buffer);

snprintf(buffer, kBufferSize, " pinning_policy.mid_percent: %" PRIu32 "\n",
snprintf(buffer, kBufferSize, " mid_percent: %" PRIu32 "\n",
options_.mid_percent);
ret.append(buffer);

Expand Down

0 comments on commit 4d3c988

Please sign in to comment.