Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the pinning policy options same as block_cache/metadata_cache #805

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Display the pinning policy options same as block_cache/metadata_cache #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d13bb15
Display the pinning policy options same as block_cache/metadata_cache
udi-speedb Jan 7, 2024
a8cdaf9
Merge branch 'main' into 804-log-consistencydisplay-the-pinning-polic…
Yuval-Ariel Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
### Enhancements

### Bug Fixes
* LOG Consistency:Display the pinning policy options same as block cache options / metadata cache options (#804).

### Miscellaneous
* WriteController logging: Remove redundant reports when WC is not shared between dbs
Expand Down Expand Up @@ -44,6 +45,7 @@ RocksDB has a value of 10 by default and we've added the option to randomize the
* Proactive Flushes: Have the initiator return a correct answer when it was requested to initate a flush (#812).
* stress test: Adding a trace file by default in PR https://github.com/speedb-io/speedb/pull/797 has revealed some incompatibilities between the trace file and several configurations (more details in https://github.com/speedb-io/speedb/issues/813). Keep the trace file and remove the IsDone assertion.


### Miscellaneous
* Remove leftover references to ROCKSDB_LITE (#755).
* Options: Set compaction_readahead_size default to 0. The current default of 2Mb is not optimal for most of our use cases. Having a value of 0 means that the FS will use its default size for prefetching (true only with https://github.com/speedb-io/speedb/pull/788).
Expand Down
7 changes: 3 additions & 4 deletions plugin/speedb/pinning_policy/scoped_pinning_policy.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,16 @@ std::string ScopedPinningPolicy::GetPrintableOptions() const {
const int kBufferSize = 200;
char buffer[kBufferSize];

snprintf(buffer, kBufferSize,
" pinning_policy.capacity: %" ROCKSDB_PRIszt "\n",
snprintf(buffer, kBufferSize, " capacity: %" ROCKSDB_PRIszt "\n",
options_.capacity);
ret.append(buffer);

snprintf(buffer, kBufferSize,
" pinning_policy.last_level_with_data_percent: %" PRIu32 "\n",
" last_level_with_data_percent: %" PRIu32 "\n",
options_.last_level_with_data_percent);
ret.append(buffer);

snprintf(buffer, kBufferSize, " pinning_policy.mid_percent: %" PRIu32 "\n",
snprintf(buffer, kBufferSize, " mid_percent: %" PRIu32 "\n",
options_.mid_percent);
ret.append(buffer);

Expand Down
Loading