Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teoSim sensors #26

Open
2 of 4 tasks
jgvictores opened this issue Dec 3, 2019 · 12 comments
Open
2 of 4 tasks

teoSim sensors #26

jgvictores opened this issue Dec 3, 2019 · 12 comments
Assignees

Comments

@jgvictores
Copy link
Member

jgvictores commented Dec 3, 2019

teoSim sensors (and how relates to base apps, and ros launch/spawn)

  • YarpOpenraveRGBDSensor
  • YarpOpenraveAnalogSensors: ForceTorque
  • YarpOpenraveAnalogSensors: IMU
  • YarpOpenraveGrabber

Related:

@jgvictores
Copy link
Member Author

jgvictores added a commit that referenced this issue Dec 19, 2019
jgvictores added a commit to roboticslab-uc3m/teo-openrave-models that referenced this issue Dec 19, 2019
jgvictores added a commit that referenced this issue Dec 24, 2019
- add openraveYarpPluginLoaderClient --device RGBDSensorWrapper
- #26
@jgvictores
Copy link
Member Author

jgvictores commented Dec 24, 2019

@jgvictores
Copy link
Member Author

BTW at 757082a yarpmanager was not recognizing openraveYarpPluginLoaderClient as a deployer.

@PeterBowman
Copy link
Member

BTW at 757082a yarpmanager was not recognizing openraveYarpPluginLoaderClient as a deployer.

AFAIK you'll only use the deployer tag for yarpdev to spare some characters and avoid an explicit --device parameter (example).

@jgvictores
Copy link
Member Author

jgvictores commented Dec 24, 2019

AFAIK you'll only use the deployer tag for yarpdev to spare some characters and avoid an explicit --device parameter (example).

Just a small rant on https://github.com/robotology/yarp/blob/b3dff81c3739112b8f65cfd808f129bcbf4e7aa5/doc/cmd_yarpmanager.dox#L173 (https://www.yarp.it/yarpmanager.html) 🙈

@jgvictores
Copy link
Member Author

Happy with current implementation (757082a thanks to current state of openrave-yarp-plugins/programs/openraveYarpPluginLoaderClient + openrave-yarp-plugins/libraries/OpenravePlugins/OpenraveYarpPluginLoader), especially based on how it mirrors the real physical robot.

Just a tiny side note, regarding iCub simulation: https://github.com/robotology/icub-main/blob/72f4d060457f8d4e150546e6735dc161faeb9c68/app/simConfig/conf/iCub_parts_activation.ini

@jgvictores
Copy link
Member Author

  • YarpOpenraveAnalogSensors: ForceTorque

@jgvictores
Copy link
Member Author

  • YarpOpenraveAnalogSensors: IMU

Requires roboticslab-uc3m/openrave-yarp-plugins#110

@jgvictores jgvictores unpinned this issue Feb 14, 2021
@PeterBowman
Copy link
Member

PeterBowman commented Aug 1, 2023

In the meantime, we migrated to Gazebo (teo-gazebo-models). I have already adapted our sim-related XML files to this environment, also acconting for FT/IMU/RGBD sensors: ae04cf2. @jgvictores I didn't notice this issue earlier, so I'm not sure whether my changes may conflict with yours.

@jgvictores
Copy link
Member Author

jgvictores commented Aug 14, 2023

@jgvictores I didn't notice this issue earlier, so I'm not sure whether my changes may conflict with yours.

Mmmm... There were no unmerged branches left dangling behind, and I'm only seeing port name improvements (which could be backported* to OR if required), I think everything is okay. 😄

* Not sure if correctly phrased here, but I think it is sufficient to transmit the idea. ^^

@jgvictores
Copy link
Member Author

Regarding OpenRAVE-based teoSim, vision aspects at

<!-- VISION -->
<module>
<name>yarpview</name>
<parameters>--name /yarpview/teoSim/rgbImage:i --title "RGB"</parameters>
<node>localhost</node>
</module>
<connection>
<from>/teoSim/camera/rgbImage:o</from>
<to>/yarpview/teoSim/rgbImage:i</to>
<!-- protocol? -->
</connection>
<module>
<name>yarpview</name>
<parameters>--name /yarpview/teoSim/depthImageMono:i --title "Depth mono"</parameters>
<node>localhost</node>
</module>
<connection>
<from>/teoSim/camera/depthImage:o</from>
<to>/yarpview/teoSim/depthImageMono:i</to>
<protocol>udp+recv.portmonitor+type.dll+file.depthimage_to_mono</protocol>
</connection>
<module>
<name>yarpview</name>
<parameters>--name /yarpview/teoSim/depthImageRGB:i --title "Depth RGB"</parameters>
<node>localhost</node>
</module>
<connection>
<from>/teoSim/camera/depthImage:o</from>
<to>/yarpview/teoSim/depthImageRGB:i</to>
<protocol>udp+recv.portmonitor+type.dll+file.depthimage_to_rgb</protocol>
</connection>
/camera should be renamed to /xtion to match the real counterpart.

Note that to achieve this, some changes might have to be made at the https://github.com/roboticslab-uc3m/openrave-yarp-plugins level, as --name /xtion is not being attended (dispite "name" support for prefix at https://www.yarp.it/v3.7/RgbdSensor__nws__yarp_8cpp_source.html) at

<module>
<name>openraveYarpPluginLoaderClient</name>
<parameters>--device rgbdSensor_nws_yarp --subdevice YarpOpenraveRGBDSensor --robotIndex 0 --depthSensorIndex 0</parameters>
<node>localhost</node>
</module>

@PeterBowman
Copy link
Member

Note that to achieve this, some changes might have to be made at the https://github.com/roboticslab-uc3m/openrave-yarp-plugins level, as --name /xtion is not being attended (dispite "name" support for prefix at https://www.yarp.it/v3.7/RgbdSensor__nws__yarp_8cpp_source.html) at

Our plugin loader overrides the --name parameter (ref). The correct way (according to this implementation) is to use --forceWrite (value-less) along with --name:

openraveYarpPluginLoaderClient --device rgbdSensor_nws_yarp --subdevice YarpOpenraveRGBDSensor --robotIndex 0 --depthSensorIndex 0 --name /teoSim/xtion --forceName

That being said, I would vote for making this port name more generic. In teo-gazebo-models, the port prefix I picked is /camera (ref).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants