-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hub): display onboarding only when user has no builds #1947
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR modifies the actors onboarding screen logic to display based on build count rather than actor count, providing a more accurate representation of whether a user has started deploying actors.
- Changed data fetching in
/frontend/apps/hub/src/routes/_authenticated/_layout/projects/$projectNameId/environments/$environmentNameId/actors.tsx
fromuseSuspenseInfiniteQuery
touseSuspenseQuery
- Added new
actorBuildsCountQueryOptions
in/frontend/apps/hub/src/domains/project/queries/actors/query-options.ts
to efficiently count builds - Simplified onboarding display condition by removing tags and includeDestroyed parameters from query options
- Modified onboarding visibility to only show when there are zero builds, regardless of filter state
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...actorBuildsQueryOptions({ projectNameId, environmentNameId }), | ||
select: (data) => data.builds.length, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: spreading actorBuildsQueryOptions here inherits the 2000ms refetchInterval, which may be unnecessarily frequent for just a count. Consider if this needs its own refetch interval.
Deploying rivet-hub with Cloudflare Pages
|
Deploying rivet with Cloudflare Pages
|
ef5887d
to
1e1fc74
Compare
4b5dfcf
to
e57ca0d
Compare
Merge activity
|
<!-- Please make sure there is an issue that this PR is correlated to. --> Closes FRONT-601 ## Changes <!-- If there are frontend changes, please include screenshots. -->
Closes FRONT-601
Changes