feat(hub): add separate protocol for actor inspect #1946

jog1t · 2025-01-28T00:58:31Z

Closes ACTR-32

Discussion points

Current implementation vs. an additional layer of abstraction Actor > { ActorUser, ActorInspect )

cloudflare-workers-and-pages · 2025-01-28T00:58:31Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`1e1fc74`
Status:	✅ Deploy successful!
Preview URL:	https://6fa5a81e.rivet-hub-7jb.pages.dev
Branch Preview URL:	https://01-28-feat-add-separate-prot.rivet-hub-7jb.pages.dev

View logs

jog1t · 2025-01-28T00:58:36Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

linear · 2025-01-28T01:00:51Z

ACTR-32 Make inspector connections a special connection type

cloudflare-workers-and-pages · 2025-01-28T01:02:49Z

Deploying rivet with Cloudflare Pages

Latest commit:	`1e1fc74`
Status:	✅ Deploy successful!
Preview URL:	https://1269109f.rivet.pages.dev
Branch Preview URL:	https://01-28-feat-add-separate-prot.rivet.pages.dev

View logs

linear · 2025-01-28T01:02:51Z

FRONT-601 Stopping the manager goes back to welcome screen and i can’t access actor ui

greptile-apps

PR Summary

This PR introduces a separate protocol for actor inspection, significantly refactoring the actor communication and inspection mechanisms across the codebase.

Critical logical error in frontend/apps/hub/src/domains/project/components/actors/actors-actor-details.tsx where enabled={!data.destroyedAt || !data.endpoint} should likely be enabled={!data.destroyedAt && data.endpoint} to properly handle actor state
New ActorInspection class in sdks/actor/runtime/src/inspect.ts needs improved error handling for WebSocket connection failures and resource cleanup
Potential type safety issue in frontend/apps/hub/src/domains/project/queries/actors/query-options.ts with undocumented URL property using ts-ignore flags
Added [INSPECT_SYMBOL]() in sdks/actor/runtime/src/connection.ts improves encapsulation but should include documentation for symbol usage
New validateMessageEvent and handleMessageEvent functions in sdks/actor/runtime/src/event.ts need additional error cases for malformed messages

_{13 file(s) reviewed, 11 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

frontend/apps/hub/src/domains/project/components/actors/actors-actor-details.tsx

frontend/apps/hub/src/domains/project/components/actors/worker/actor-worker-context.tsx

sdks/actor/runtime/src/errors.ts

sdks/actor/runtime/src/event.ts

sdks/actor/runtime/src/inspect.ts

sdks/actor/runtime/src/log.ts

NathanFlurry · 2025-01-28T05:41:26Z

@greptileai

greptile-apps

PR Summary

This PR continues the implementation of a separate protocol for actor inspection, focusing on the actor runtime and connection handling components.

Added throttling mechanism in sdks/actor/runtime/src/inspect.ts for state and connection change notifications to prevent excessive updates
Improved error handling in sdks/actor/runtime/src/actor.ts with new Unsupported error class for feature-specific failures
Refactored ActorWorkerContainer in frontend/apps/hub/src/domains/project/components/actors/worker/actor-worker-container.ts to use direct endpoints instead of manager URLs
Added dedicated inspectLogger in sdks/actor/runtime/src/log.ts for better debugging of inspection-related operations
Implemented proper cleanup in sdks/actor/runtime/src/actor.ts for WebSocket connections with a 1.5 second timeout

_{13 file(s) reviewed, 7 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-01-28T05:42:24Z

frontend/apps/hub/src/domains/project/components/actors/actors-actor-details.tsx

+			<ActorWorkerContextProvider
+				enabled={!data.destroyedAt}
+				endpoint={data.endpoint}
+				{...props}
+			>


style: endpoint prop is passed before spreading ...props which could lead to endpoint being overridden if it exists in props

greptile-apps · 2025-01-28T05:42:58Z

frontend/packages/components/src/ui/button.tsx

-				{!size?.includes("icon") && isLoading ? null : (
-					<Slottable>{children}</Slottable>
-				)}
+				{isIcon && isLoading ? null : <Slottable>{children}</Slottable>}


logic: This change may have introduced a regression. Previously, children were hidden for non-icon buttons during loading (!size?.includes('icon') && isLoading). Now children are only hidden for icon buttons during loading (isIcon && isLoading). This means non-icon buttons will show both the loading spinner and children simultaneously.

greptile-apps · 2025-01-28T05:44:16Z

sdks/actor/runtime/src/errors.ts

@@ -150,6 +150,12 @@ export class StateTooLarge extends ActorError {
 	}
 }

+export class Unsupported extends ActorError {
+	constructor(feature: string) {
+		super("unsupported", `Unsupported feature: ${feature}`);


style: consider using backticks around feature name for consistency with other error messages like InvalidProtocolVersion

greptile-apps · 2025-01-28T05:44:27Z

sdks/actor/runtime/src/event.ts

+				throw new errors.Unsupported("RPC");
+			}
+
+			const { i: id, n: name, a: args = [] } = message.body.rr;


logic: No validation on RPC name or args array length. Could lead to security issues if malicious input is provided.

greptile-apps · 2025-01-28T05:44:28Z

sdks/actor/runtime/src/event.ts

+				throw new errors.Unsupported("Subscriptions");
+			}
+
+			const { e: eventName, s: subscribe } = message.body.sr;


logic: No validation on eventName - should check for empty string or invalid characters that could cause issues.

greptile-apps · 2025-01-28T05:44:28Z

sdks/actor/runtime/src/event.ts

+			rpcRequestId = id;
+
+			const ctx = new Rpc<A>(conn);
+			const output = await handlers.onExecuteRpc(ctx, name, args);


style: No timeout handling for RPC execution. Long-running RPCs could block the event loop.

greptile-apps · 2025-01-28T05:44:29Z

sdks/actor/runtime/src/event.ts

+		if (error instanceof errors.ActorError && error.public) {
+			code = error.code;
+			message = String(error);
+			metadata = error.metadata;
+		} else {
+			code = errors.INTERNAL_ERROR_CODE;
+			message = errors.INTERNAL_ERROR_DESCRIPTION;
+			internal = true;
+		}


logic: Error handling could leak sensitive information if error.public is true but error.metadata contains sensitive data.

graphite-app · 2025-01-28T05:47:39Z

Merge activity

Jan 28, 12:47 AM EST: A user added this pull request to the Graphite merge queue.
Jan 28, 12:48 AM EST: CI is running for this PR on a draft PR: #1949
Jan 28, 12:49 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1949.

Closes ACTR-32 ## Discussion points - [ ] Current implementation vs. an additional layer of abstraction `Actor > { ActorUser, ActorInspect )`

jog1t mentioned this pull request Jan 28, 2025

feat(hub): add more options to create actor form #1944

Closed

jog1t self-assigned this Jan 28, 2025

jog1t requested a review from NathanFlurry January 28, 2025 00:58

jog1t marked this pull request as ready for review January 28, 2025 01:02

greptile-apps bot reviewed Jan 28, 2025

View reviewed changes

jog1t force-pushed the 01-28-feat_add_separate_protocol_for_actor_inspect branch from 35845f3 to ef5887d Compare January 28, 2025 01:15

jog1t changed the title ~~feat: add separate protocol for actor inspect~~ feat(hub): add separate protocol for actor inspect Jan 28, 2025

This was referenced Jan 28, 2025

feat(hub): display onboarding only when user has no builds #1947

Closed

feat(site): add orama search #1948

Closed

feat: add separate protocol for actor inspect

1e1fc74

NathanFlurry force-pushed the 01-27-feat_add_more_options_to_create_actor_form branch from cc63118 to ac2e9de Compare January 28, 2025 05:20

NathanFlurry force-pushed the 01-28-feat_add_separate_protocol_for_actor_inspect branch from ef5887d to 1e1fc74 Compare January 28, 2025 05:39

NathanFlurry approved these changes Jan 28, 2025

View reviewed changes

greptile-apps bot reviewed Jan 28, 2025

View reviewed changes

graphite-app bot closed this Jan 28, 2025

graphite-app bot deleted the 01-28-feat_add_separate_protocol_for_actor_inspect branch January 28, 2025 05:49

github-actions bot mentioned this pull request Jan 27, 2025

chore(main): release 24.7.0 #1839

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(hub): add separate protocol for actor inspect #1946

feat(hub): add separate protocol for actor inspect #1946

jog1t commented Jan 28, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 28, 2025 •

edited

Loading

jog1t commented Jan 28, 2025 •

edited

Loading

linear bot commented Jan 28, 2025

cloudflare-workers-and-pages bot commented Jan 28, 2025 •

edited

Loading

linear bot commented Jan 28, 2025

greptile-apps bot left a comment

NathanFlurry commented Jan 28, 2025

greptile-apps bot left a comment

greptile-apps bot Jan 28, 2025

greptile-apps bot Jan 28, 2025

greptile-apps bot Jan 28, 2025

greptile-apps bot Jan 28, 2025

greptile-apps bot Jan 28, 2025

greptile-apps bot Jan 28, 2025

greptile-apps bot Jan 28, 2025

graphite-app bot commented Jan 28, 2025 •

edited

Loading

feat(hub): add separate protocol for actor inspect #1946

feat(hub): add separate protocol for actor inspect #1946

Conversation

jog1t commented Jan 28, 2025 • edited Loading

Discussion points

cloudflare-workers-and-pages bot commented Jan 28, 2025 • edited Loading

Deploying rivet-hub with Cloudflare Pages

jog1t commented Jan 28, 2025 • edited Loading

How to use the Graphite Merge Queue

linear bot commented Jan 28, 2025

cloudflare-workers-and-pages bot commented Jan 28, 2025 • edited Loading

Deploying rivet with Cloudflare Pages

linear bot commented Jan 28, 2025

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

NathanFlurry commented Jan 28, 2025

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Jan 28, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 28, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 28, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 28, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 28, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 28, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 28, 2025

Choose a reason for hiding this comment

graphite-app bot commented Jan 28, 2025 • edited Loading

Merge activity

jog1t commented Jan 28, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 28, 2025 •

edited

Loading

jog1t commented Jan 28, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 28, 2025 •

edited

Loading

graphite-app bot commented Jan 28, 2025 •

edited

Loading