Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hub): add more options to create actor form #1944

Closed
wants to merge 1 commit into from
Closed

feat(hub): add more options to create actor form #1944

wants to merge 1 commit into from

Conversation

jog1t
Copy link
Contributor

@jog1t jog1t commented Jan 27, 2025 •
edited
Loading

Closes FRONT-605

Changes

image

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 27, 2025 •
edited
Loading

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: ac2e9de
Status: ✅  Deploy successful!
Preview URL: https://b9a59c23.rivet-hub-7jb.pages.dev
Branch Preview URL: https://01-27-feat-add-more-options.rivet-hub-7jb.pages.dev

View logs

@jog1t Graphite App
Copy link
Contributor Author

jog1t commented Jan 27, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jog1t jog1t self-assigned this Jan 27, 2025
@linear Linear
Copy link

linear bot commented Jan 27, 2025

FRONT-605 Improve Actor create UI

@jog1t jog1t requested a review from NathanFlurry January 27, 2025 22:03
@jog1t jog1t changed the title feat: add more options to create actor form feat(hub): add more options to create actor form Jan 27, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 27, 2025 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: ac2e9de
Status: ✅  Deploy successful!
Preview URL: https://114cbe98.rivet.pages.dev
Branch Preview URL: https://01-27-feat-add-more-options.rivet.pages.dev

View logs

@jog1t jog1t marked this pull request as ready for review January 28, 2025 00:56
@jog1t jog1t force-pushed the 01-27-feat_add_more_options_to_create_actor_form branch from c282e9f to cc63118 Compare January 28, 2025 00:58
greptile-apps[bot]
greptile-apps bot reviewed Jan 28, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the actor creation form by adding region selection, tags, and parameter configuration options, moving away from default-only settings.

  • Added RegionSelect component in /frontend/apps/hub/src/domains/project/components/region-select.tsx for region selection via Combobox with search functionality
  • Implemented JSON parameter validation and input in actor-create-form.tsx for configuring actor parameters
  • Added tag management system in build-tags-form.tsx with key-value validation ensuring unique keys
  • Modified useCreateActorFromSdkMutation in mutations.ts to handle new region and parameter options
  • Reduced actor builds refetch interval from 5000ms to 2000ms in query-options.ts for more frequent updates

8 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile

frontend/apps/hub/src/domains/project/components/dialogs/create-actor-dialog.tsx Show resolved Hide resolved
frontend/apps/hub/src/domains/project/components/region-select.tsx Outdated Show resolved Hide resolved
frontend/apps/hub/src/domains/project/forms/actor-create-form.tsx Show resolved Hide resolved
frontend/apps/hub/src/domains/project/queries/actors/mutations.ts
}: {
projectNameId: string;
environmentNameId: string;
buildId: string;
region: string;
parameters: unknown;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: parameters type should be more specific than 'unknown' to ensure type safety

frontend/apps/hub/src/domains/project/queries/actors/mutations.ts Show resolved Hide resolved
...es/_authenticated/_layout/projects/$projectNameId/environments/$environmentNameId/actors.tsx Show resolved Hide resolved
frontend/packages/components/src/ui/button.tsx Show resolved Hide resolved
This was referenced Jan 28, 2025
Closed
Closed
Closed
@NathanFlurry Graphite App
Copy link
Member

@greptileai

greptile-apps[bot]
greptile-apps bot reviewed Jan 28, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

No major changes found since last review. The previous review comprehensively covered the key changes including the addition of region selection, parameter configuration, tag management, and mutation handling. The files shown in this review are the same as those previously analyzed, with no significant new modifications to highlight.

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@NathanFlurry NathanFlurry force-pushed the 01-27-feat_add_more_options_to_create_actor_form branch from cc63118 to ac2e9de Compare January 28, 2025 05:20
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jan 28, 2025 •
edited
Loading

Merge activity

  • Jan 28, 12:47 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 28, 12:48 AM EST: CI is running for this PR on a draft PR: #1949
  • Jan 28, 12:49 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1949.

NathanFlurry pushed a commit that referenced this pull request Jan 28, 2025
@jog1t
feat(hub): add more options to create actor form (#1944)
6b6af49 
Closes FRONT-605

<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

![image](https://github.com/user-attachments/assets/749eb6b9-5be3-4bdd-b339-12bb540e2b0d)

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Jan 28, 2025
@graphite-app graphite-app bot deleted the 01-27-feat_add_more_options_to_create_actor_form branch January 28, 2025 05:49
@github-actions github-actions bot mentioned this pull request Jan 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@NathanFlurry NathanFlurry NathanFlurry approved these changes

Assignees

@jog1t jog1t

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jog1t @NathanFlurry