-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(workflows): allow op ctx to do all the things #1938
base: 01-16-feat_fdb_sqlite_workflows_driver
Are you sure you want to change the base?
fix(workflows): allow op ctx to do all the things #1938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR modifies the Chirp workflow system to allow operation contexts to dispatch workflows, signals, and messages while maintaining safety constraints against recursive workflow dispatching.
- Added
from_workflow
flag inSignalBuilder
andWorkflowBuilder
to prevent dispatching from within workflow operations - Changed
MessageBuilder
to own itsMessageCtx
rather than borrowing it, removing lifetime parameters and simplifying the API - Made
OperationCtx::new()
asynchronous and addedMessageCtx
support for message operations - Added safety checks in builders to prevent potential infinite recursion while allowing more flexible operation context capabilities
- Standardized workflow/signal/message handling patterns across different context types (Api, Test, Standalone)
💡 (4/5) You can add custom instructions or style guidelines for the bot here!
11 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
packages/common/chirp-workflow/core/src/ctx/versioned_workflow.rs
Outdated
Show resolved
Hide resolved
Deploying rivet with
|
Latest commit: |
77479e1
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f2da1bdd.rivet.pages.dev |
Branch Preview URL: | https://01-24-fix-workflows-allow-op.rivet.pages.dev |
296889a
to
7171a84
Compare
d0218f6
to
c2ae964
Compare
7171a84
to
ff931bf
Compare
c2ae964
to
6153a52
Compare
ff931bf
to
1fbcc04
Compare
6153a52
to
50e531c
Compare
1fbcc04
to
0ec8ed1
Compare
50e531c
to
4c4f509
Compare
0ec8ed1
to
fddc413
Compare
4c4f509
to
866c3d5
Compare
fddc413
to
04f5deb
Compare
866c3d5
to
724da15
Compare
724da15
to
d541a3f
Compare
9883dbd
to
5d9ba6a
Compare
d541a3f
to
5300be2
Compare
5d9ba6a
to
eb25766
Compare
5300be2
to
4d41962
Compare
eb25766
to
2785d85
Compare
4d41962
to
45c78d9
Compare
45c78d9
to
77479e1
Compare
Changes