fix(cluster): create new cluster server wf with stateful loop #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces significant changes to the cluster service's server management system, primarily focusing on implementing stateful loops for better workflow control.
- Introduces new
server::Workflow2with structured state management viaStatestruct in/packages/services/cluster/src/workflows/server/mod.rs - Removes
ServerCreatesignal from datacenter workflow in/packages/services/cluster/src/workflows/datacenter/mod.rs, indicating a shift in server provisioning approach - Modifies scale workflow to handle version-specific server workflows with conditional dispatching in
/packages/services/cluster/src/workflows/datacenter/scale.rs - Comments out critical integration tests for server provisioning and GC functionality, which needs to be addressed to maintain testing coverage
- Implements version-aware workflow dispatching using
ctx.check_version(2)for backward compatibility during migration
6 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
cfa099f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://08a2a2e4.rivet.pages.dev |
| Branch Preview URL: | https://01-24-fix-cluster-create-new.rivet.pages.dev |
This was referenced Jan 24, 2025
NathanFlurry
approved these changes
Jan 27, 2025
Merge activity
|
NathanFlurry
pushed a commit
that referenced
this pull request
Jan 27, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Deploying rivet-hub with
|
| Latest commit: |
cfa099f
|
| Status: | ⚡️ Build in progress... |
graphite-app
bot
deleted the
01-24-fix_cluster_create_new_cluster_server_wf_with_stateful_loop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes