chore: flatten all .gitignores in to root & merge in to .dockerignore #1981
Conversation
Deploying rivet with
|
| Latest commit: |
ffca06a
|
| Status: | ⚡️ Build in progress... |
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Deploying rivet-hub with
|
| Latest commit: |
ffca06a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://286e91f5.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://01-30-chore-flatten-all--git.rivet-hub-7jb.pages.dev |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR consolidates multiple .gitignore files into the root .gitignore and merges their patterns into .dockerignore, improving maintainability by centralizing ignore patterns.
- Migrated frontend-specific patterns from
/frontend/.gitignoreto root, including Next.js, log files, and environment patterns - Added icons-specific exclusions in root .gitignore/dockerignore for
frontend/packages/icons/src/*with package.json exception - Removed redundant
.turboentry since it's covered by**/.turbopattern - Added documentation header in root .gitignore about keeping sync with .dockerignore
- Preserved Rust-specific patterns from test dockerfiles for target/, debug/, and *.rs.bk files
18 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
| **/.DS_Store | ||
|
|
||
| # Env | ||
| .env*.local | ||
|
|
||
| # Rust | ||
| **/target |
There was a problem hiding this comment.
style: duplicate entry with line 21 (**/target)
| **/.cache/ | ||
| **/.next/ | ||
| **/.turbo | ||
| **/.yarn | ||
| **/dist/ | ||
| **/node_modules/ | ||
| **/target |
There was a problem hiding this comment.
style: Redundant entry - **/target is already defined on line 11
| **/target |
| export interface Cache<Key extends object, Value> { | ||
| delete(key: Key): boolean; | ||
| get(key: Key): Value | undefined; | ||
| set(key: Key, value: any): any; |
There was a problem hiding this comment.
style: set() method's return type is 'any' which could be more specific (should match Map's set() return type of Map<Key, Value>)
| * **NOTE**: This does not include `BigInt64Array` and | ||
| * `BitUint64Array` because those are part of ES2020 and | ||
| * not supported by certain TS configurations. If using |
There was a problem hiding this comment.
syntax: typo in comment: 'BitUint64Array' should be 'BigUint64Array'
| * **NOTE**: This does not include `BigInt64Array` and | |
| * `BitUint64Array` because those are part of ES2020 and | |
| * not supported by certain TS configurations. If using | |
| * **NOTE**: This does not include `BigInt64Array` and | |
| * `BigUint64Array` because those are part of ES2020 and | |
| * not supported by certain TS configurations. If using |
| TypeEqualityComparator, | ||
| } from "./internalTypes.d.ts"; | ||
| /** | ||
| * Combine two comparators into a single comparators. |
There was a problem hiding this comment.
syntax: typo in comment: 'comparators' should be 'comparator'
| * Combine two comparators into a single comparators. | |
| * Combine two comparators into a single comparator. |
NathanFlurry
force-pushed
the
01-30-chore_flatten_all_.gitignores_in_to_root_merge_in_to_.dockerignore
branch
from
976fd2b to
ffca06a
Compare
Merge activity
|
…#1981) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
01-30-chore_flatten_all_.gitignores_in_to_root_merge_in_to_.dockerignore
branch
Changes