CDK RemovalPolicy maps to Pulumi retainOnDelete #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR maps CloudFormation [DeletionPolicy](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-deletionpolicy.html) to Pulumi `retainOnDelete`. **`DeletionPolicy` => `retainOnDelete`** - `Delete` => `false` - `Retain` => `true` - `RetainExceptOnCreate` => `true` - `Snapshot` => `true` Looking specifically for validation on `Snapshot` mapping. This functionality does not exist in Pulumi so I decided to err on the side of caution and retain the resource instead of deleting it. We log a warning in this case and they should see the retention in the preview. closes #188
corymhall
force-pushed
the
corymhall/removal-policy
branch
from
35f621d to
6f35433
Compare
t0yv0
reviewed
Nov 18, 2024
| super(app, id, options); | ||
| new s3.Bucket(this, 'testbucket', { | ||
| bucketName: bucketName, | ||
| removalPolicy: RemovalPolicy.RETAIN, |
t0yv0
reviewed
Nov 18, 2024
| case cdk.CfnDeletionPolicy.RETAIN_EXCEPT_ON_CREATE: | ||
| return true; | ||
| case cdk.CfnDeletionPolicy.SNAPSHOT: | ||
| warn(`DeletionPolicy Snapshot is not supported. Resource '${logicalId}' will be retained.`); |
t0yv0
reviewed
Nov 18, 2024
| case cdk.CfnDeletionPolicy.DELETE: | ||
| return false; | ||
| case cdk.CfnDeletionPolicy.RETAIN: | ||
| case cdk.CfnDeletionPolicy.RETAIN_EXCEPT_ON_CREATE: |
There was a problem hiding this comment.
Nit: Comment from L312 can move here :) But I found it. Good.
t0yv0
approved these changes
Nov 18, 2024
|
This PR has been shipped in release v1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR maps CloudFormation DeletionPolicy
to Pulumi
retainOnDelete.DeletionPolicy=>retainOnDeleteDelete=>falseRetain=>trueRetainExceptOnCreate=>trueSnapshot=>trueLooking specifically for validation on
Snapshotmapping. Thisfunctionality does not exist in Pulumi so I decided to err on the side
of caution and retain the resource instead of deleting it. We log a
warning in this case and they should see the retention in the preview.
closes #188