-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CDK RemovalPolicy maps to Pulumi retainOnDelete (#223)
This PR maps CloudFormation [DeletionPolicy](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-deletionpolicy.html) to Pulumi `retainOnDelete`. **`DeletionPolicy` => `retainOnDelete`** - `Delete` => `false` - `Retain` => `true` - `RetainExceptOnCreate` => `true` - `Snapshot` => `true` Looking specifically for validation on `Snapshot` mapping. This functionality does not exist in Pulumi so I decided to err on the side of caution and retain the resource instead of deleting it. We log a warning in this case and they should see the retention in the preview. closes #188
- Loading branch information
Showing
23 changed files
with
542 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| name: pulumi-aws-removal-policy | ||
| runtime: nodejs | ||
| description: removal-policy integration test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import * as s3 from 'aws-cdk-lib/aws-s3'; | ||
| import * as pulumicdk from '@pulumi/cdk'; | ||
| import { RemovalPolicy } from 'aws-cdk-lib'; | ||
| import { Config } from '@pulumi/pulumi'; | ||
| const config = new Config(); | ||
| const bucketName = config.require('bucketName'); | ||
|
|
||
| class RemovalPolicyStack extends pulumicdk.Stack { | ||
| constructor(app: pulumicdk.App, id: string, options?: pulumicdk.StackOptions) { | ||
| super(app, id, options); | ||
| new s3.Bucket(this, 'testbucket', { | ||
| bucketName: bucketName, | ||
| removalPolicy: RemovalPolicy.RETAIN, | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| new pulumicdk.App('app', (scope: pulumicdk.App) => { | ||
| new RemovalPolicyStack(scope, 'teststack'); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "name": "pulumi-aws-cdk", | ||
| "devDependencies": { | ||
| "@types/node": "^10.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "@pulumi/aws": "^6.0.0", | ||
| "@pulumi/aws-native": "^1.8.0", | ||
| "@pulumi/cdk": "^0.5.0", | ||
| "@pulumi/pulumi": "^3.0.0", | ||
| "aws-cdk-lib": "2.156.0", | ||
| "constructs": "10.3.0", | ||
| "esbuild": "^0.24.0" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| name: pulumi-aws-removal-policy | ||
| runtime: nodejs | ||
| description: removal-policy integration test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import * as s3 from 'aws-cdk-lib/aws-s3'; | ||
| import * as pulumicdk from '@pulumi/cdk'; | ||
| import { RemovalPolicy } from 'aws-cdk-lib'; | ||
| import { Config } from '@pulumi/pulumi'; | ||
| const config = new Config(); | ||
| const bucketName = config.require('bucketName'); | ||
|
|
||
| class RemovalPolicyStack extends pulumicdk.Stack { | ||
| constructor(app: pulumicdk.App, id: string, options?: pulumicdk.StackOptions) { | ||
| super(app, id, options); | ||
| new s3.Bucket(this, 'testbucket', { | ||
| bucketName: bucketName, | ||
| removalPolicy: RemovalPolicy.DESTROY, | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| new pulumicdk.App('app', (scope: pulumicdk.App) => { | ||
| new RemovalPolicyStack(scope, 'teststack'); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "name": "pulumi-aws-cdk", | ||
| "devDependencies": { | ||
| "@types/node": "^10.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "@pulumi/aws": "^6.0.0", | ||
| "@pulumi/aws-native": "^1.8.0", | ||
| "@pulumi/cdk": "^0.5.0", | ||
| "@pulumi/pulumi": "^3.0.0", | ||
| "aws-cdk-lib": "2.156.0", | ||
| "constructs": "10.3.0", | ||
| "esbuild": "^0.24.0" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "strict": true, | ||
| "outDir": "bin", | ||
| "target": "es2019", | ||
| "module": "commonjs", | ||
| "moduleResolution": "node", | ||
| "sourceMap": true, | ||
| "experimentalDecorators": true, | ||
| "pretty": true, | ||
| "noFallthroughCasesInSwitch": true, | ||
| "noImplicitReturns": true, | ||
| "forceConsistentCasingInFileNames": true | ||
| }, | ||
| "include": [ | ||
| "./*.ts" | ||
| ] | ||
| } |
Oops, something went wrong.