-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDK RemovalPolicy maps to Pulumi retainOnDelete #223
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8c45e67
CDK RemovalPolicy maps to Pulumi retainOnDelete
corymhall 6f35433
setting integration test buckets to destroy
corymhall 0a54451
missed a removal policy
corymhall 12f2ce1
moving docs
corymhall 8a07578
moving tests to us-east-2
corymhall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| name: pulumi-aws-removal-policy | ||
| runtime: nodejs | ||
| description: removal-policy integration test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import * as s3 from 'aws-cdk-lib/aws-s3'; | ||
| import * as pulumicdk from '@pulumi/cdk'; | ||
| import { RemovalPolicy } from 'aws-cdk-lib'; | ||
| import { Config } from '@pulumi/pulumi'; | ||
| const config = new Config(); | ||
| const bucketName = config.require('bucketName'); | ||
|
|
||
| class RemovalPolicyStack extends pulumicdk.Stack { | ||
| constructor(app: pulumicdk.App, id: string, options?: pulumicdk.StackOptions) { | ||
| super(app, id, options); | ||
| new s3.Bucket(this, 'testbucket', { | ||
| bucketName: bucketName, | ||
| removalPolicy: RemovalPolicy.RETAIN, | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| new pulumicdk.App('app', (scope: pulumicdk.App) => { | ||
| new RemovalPolicyStack(scope, 'teststack'); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "name": "pulumi-aws-cdk", | ||
| "devDependencies": { | ||
| "@types/node": "^10.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "@pulumi/aws": "^6.0.0", | ||
| "@pulumi/aws-native": "^1.8.0", | ||
| "@pulumi/cdk": "^0.5.0", | ||
| "@pulumi/pulumi": "^3.0.0", | ||
| "aws-cdk-lib": "2.156.0", | ||
| "constructs": "10.3.0", | ||
| "esbuild": "^0.24.0" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| name: pulumi-aws-removal-policy | ||
| runtime: nodejs | ||
| description: removal-policy integration test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import * as s3 from 'aws-cdk-lib/aws-s3'; | ||
| import * as pulumicdk from '@pulumi/cdk'; | ||
| import { RemovalPolicy } from 'aws-cdk-lib'; | ||
| import { Config } from '@pulumi/pulumi'; | ||
| const config = new Config(); | ||
| const bucketName = config.require('bucketName'); | ||
|
|
||
| class RemovalPolicyStack extends pulumicdk.Stack { | ||
| constructor(app: pulumicdk.App, id: string, options?: pulumicdk.StackOptions) { | ||
| super(app, id, options); | ||
| new s3.Bucket(this, 'testbucket', { | ||
| bucketName: bucketName, | ||
| removalPolicy: RemovalPolicy.DESTROY, | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| new pulumicdk.App('app', (scope: pulumicdk.App) => { | ||
| new RemovalPolicyStack(scope, 'teststack'); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "name": "pulumi-aws-cdk", | ||
| "devDependencies": { | ||
| "@types/node": "^10.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "@pulumi/aws": "^6.0.0", | ||
| "@pulumi/aws-native": "^1.8.0", | ||
| "@pulumi/cdk": "^0.5.0", | ||
| "@pulumi/pulumi": "^3.0.0", | ||
| "aws-cdk-lib": "2.156.0", | ||
| "constructs": "10.3.0", | ||
| "esbuild": "^0.24.0" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "strict": true, | ||
| "outDir": "bin", | ||
| "target": "es2019", | ||
| "module": "commonjs", | ||
| "moduleResolution": "node", | ||
| "sourceMap": true, | ||
| "experimentalDecorators": true, | ||
| "pretty": true, | ||
| "noFallthroughCasesInSwitch": true, | ||
| "noImplicitReturns": true, | ||
| "forceConsistentCasingInFileNames": true | ||
| }, | ||
| "include": [ | ||
| "./*.ts" | ||
| ] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice