Vaquita species add #1514
Merged
Vaquita species add #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1514 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 121 124 +3
Lines 4178 4191 +13
Branches 588 588
=======================================
+ Hits 4172 4185 +13
Misses 3 3
Partials 3 3
☔ View full report in Codecov by Sentry. |
igronau
force-pushed
the
vaquita_species_add
branch
from
789bbdb to
a2091db
Compare
Merged
petrelharp
approved these changes
Oct 10, 2023
|
Let's make sure I didn't mess this up, then merge. |
petrelharp
reviewed
Oct 10, 2023
Implemented PhoSin species (Vaquita). First version (before QC) now also adding the test file added explanation for recombination rate and fixed issues in docs Apply suggestions from code review Update stdpopsim/catalog/PhoSin/species.py cache bump
petrelharp
force-pushed
the
vaquita_species_add
branch
from
7b9dcc6 to
262ad39
Compare
|
I ran the tests locally, and they're wroking, so even if this doesn't work after the cache bump I'm going to merge this with or without the CI. |
Closed
|
Okay - everything passed except for the tests as reported in #1523, unrelated to this PR. I will merge. |
|
Looks good. Thanks, @petrelharp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version of the Vaquita species model. We still need to figure out the recombination rate. See #1508.