-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhoSin annotations #1520
PhoSin annotations #1520
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1520 +/- ##
==========================================
- Coverage 99.85% 99.85% -0.01%
==========================================
Files 127 121 -6
Lines 4260 4178 -82
Branches 591 588 -3
==========================================
- Hits 4254 4172 -82
Misses 3 3
Partials 3 3 ☔ View full report in Codecov by Sentry. |
i'm going to rerun the test suite, to see if #1532 actually worked (looks like all but one of the grid errored out with "conda environment not found") |
Hey @nspope not sure if it's relevant but this won't pass the stdpopsim pytest until we get these files uploaded to AWS |
that's fine-- just need to get the test suite to run in the first place! Which it seems they aren't, despite #1532 |
@chriscrsmith would you mind rebasing this onto main? I think I've fixed the CI issues, and want to check that the tests actually run now (regardless of whether they fail). |
small changes md5sums updated
3b59535
to
57034a6
Compare
Hows that look, @nspope ? I see some tests running... |
Seems to be working, thanks! |
@chriscrsmith I think the correct way to do this is to actually to merge this PR and then run the annotation maintenance and it will automatically do the downloading etc. anyone mind if I do that? |
the annotations are now up on aws |
So far this includes only the annotations.py file. Waiting on #1514 to add PhoSin to catalog.
@andrewkern, how do we upload files to AWS? Currently the interval files are sitting here: