Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: project controller trying to delete readonly project #1764

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix: project controller trying to delete readonly project #1764

merged 1 commit into from
Jan 17, 2025

Conversation

floreks
Copy link
Member

@floreks floreks commented Jan 17, 2025

It should not try to remove a project if it is marked as readonly.

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.

@floreks floreks added the bug-fix This pull request fixes a bug label Jan 17, 2025
@floreks floreks self-assigned this Jan 17, 2025
@floreks floreks merged commit 6f659f8 into master Jan 17, 2025
14 checks passed
@floreks floreks deleted the fix/project-controller branch January 17, 2025 18:53
michaeljguarino pushed a commit that referenced this pull request Jan 17, 2025
@floreks @michaeljguarino
fix: project controller trying to delete readonly project (#1764)
9fce562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

Assignees

@floreks floreks

Labels
bug-fix This pull request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floreks @michaeljguarino