Skip to content

Commit

Permalink
fix: project controller trying to delete readonly project (#1764)
Browse files Browse the repository at this point in the history
  • Loading branch information
floreks authored and michaeljguarino committed Jan 17, 2025
1 parent 52815b9 commit 9fce562
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions go/controller/internal/controller/project_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ func (in *ProjectReconciler) addOrRemoveFinalizer(ctx context.Context, project *
return &requeue
}

// Remove Pipeline from Console API if it exists.
if exists {
// Remove project from Console API if it exists and is not readonly
if exists && !project.Status.IsReadonly() {
if err := in.ConsoleClient.DeleteProject(ctx, project.Status.GetID()); err != nil {
// If it fails to delete the external dependency here, return with error
// so that it can be retried.
Expand Down

0 comments on commit 9fce562

Please sign in to comment.