Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: project controller trying to delete readonly project #1764

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix: project controller trying to delete readonly project #1764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go/controller/internal/controller/project_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ func (in *ProjectReconciler) addOrRemoveFinalizer(ctx context.Context, project *
return &requeue
}

// Remove Pipeline from Console API if it exists.
if exists {
// Remove project from Console API if it exists and is not readonly
if exists && !project.Status.IsReadonly() {
if err := in.ConsoleClient.DeleteProject(ctx, project.Status.GetID()); err != nil {
// If it fails to delete the external dependency here, return with error
// so that it can be retried.
Expand Down
Loading