🔨 (db) migrate Pageview to knex #3139

sophiamersmann · 2024-01-26T09:12:41Z

Makes the Pageview TypeORM class obsolete by switching db access to knex
This PR does not do any clean-up, e.g. SQL queries in the router files are not moved, although they ultimately should live in the db folder

@coderabbitai ignore

sophiamersmann · 2024-01-26T09:12:53Z

Current dependencies on/for this PR:

🔨 (db) migrate Pageview to knex #3139 👈
🔨 (db) migrate Dataset and Source to knex #3131
🔨 make name on datasets mandatory #3143
🔨 remove obsolete tables and country standardizer #3065
🔨 add types for database rows and prepare use of knex instead of TypeORM #3064 : 1 other dependent PR (#3145 )
Extract grapher and core table types #3056
⚒️ Move types out of utils and into their own types package #3054
master

This stack of pull requests is managed by Graphite.

coderabbitai · 2024-01-26T09:13:04Z

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

github-actions · 2024-02-13T07:06:05Z

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

sophiamersmann

So weird to review muy own changes...

Looks good to me! I made two minor comments :)

sophiamersmann · 2024-02-27T15:09:46Z

baker/algolia/indexToAlgolia.tsx

@@ -196,7 +196,7 @@ function generateGdocRecords(

 // Generate records for countries, WP posts (not including posts that have been succeeded by Gdocs equivalents), and Gdocs
 const getPagesRecords = async (knex: Knex<any, any[]>) => {
-    const pageviews = await Pageview.getViewsByUrlObj()
+    const pageviews = await getAnalyticsPageviewsByUrlObj(db.knexInstance())


We create a new instance, although a knex instance is passed in.

sophiamersmann · 2024-02-27T15:10:13Z

baker/algolia/indexExplorersToAlgolia.ts

@@ -112,7 +112,7 @@ function getNullishJSONValueAsPlaintext(value: string): string {
 }

 const getExplorerRecords = async (): Promise<ExplorerRecord[]> => {
-    const pageviews = await Pageview.getViewsByUrlObj()
+    const pageviews = await getAnalyticsPageviewsByUrlObj(db.knexInstance())


Maybe it would be good to pass knex in here as well?

danyx23 · 2024-02-27T15:59:15Z

Merge activity

Feb 27, 10:59 AM EST: @danyx23 started a stack merge that includes this pull request via Graphite.
Feb 27, 11:00 AM EST: Graphite rebased this pull request as part of a merge.
Feb 27, 11:01 AM EST: @danyx23 merged this pull request with Graphite.

sophiamersmann mentioned this pull request Jan 26, 2024

🔨 (db) migrate Dataset and Source to knex #3131

Merged

danyx23 mentioned this pull request Jan 26, 2024

🔨 add types for database rows and prepare use of knex instead of TypeORM #3064

Merged

This was referenced Jan 26, 2024

⚒️ Move types out of utils and into their own types package #3054

Merged

Extract grapher and core table types #3056

Merged

sophiamersmann mentioned this pull request Jan 26, 2024

🔨 Convert SuggestedChartRevision db access to knex #3074

Closed

github-actions bot assigned sophiamersmann Jan 26, 2024

danyx23 force-pushed the db-types-migrate-dataset-and-source branch 3 times, most recently from 486942e to ce49d9f Compare January 27, 2024 00:19

This was referenced Jan 27, 2024

🔨 remove obsolete tables and country standardizer #3065

Merged

🔨 make name on datasets mandatory #3143

Merged

danyx23 force-pushed the db-types-migrate-dataset-and-source branch 2 times, most recently from a834c76 to 435d84a Compare January 29, 2024 08:38

danyx23 mentioned this pull request Jan 29, 2024

Convert users and variables types to knex #3145

Merged

danyx23 force-pushed the db-types-migrate-dataset-and-source branch 2 times, most recently from a35b059 to 009d6fb Compare January 29, 2024 14:15

github-actions bot added the stale label Feb 13, 2024

sophiamersmann added the pinned label Feb 15, 2024

danyx23 force-pushed the db-types-migrate-dataset-and-source branch from 009d6fb to 8c71da0 Compare February 22, 2024 13:31

danyx23 force-pushed the db-migrate-pageviews branch 2 times, most recently from b16610f to 4451b04 Compare February 23, 2024 17:31

danyx23 force-pushed the db-types-migrate-dataset-and-source branch from c538a40 to 92444de Compare February 27, 2024 12:07

danyx23 force-pushed the db-migrate-pageviews branch 2 times, most recently from 7c53658 to 58817f4 Compare February 27, 2024 12:24

sophiamersmann commented Feb 27, 2024

View reviewed changes

danyx23 force-pushed the db-migrate-pageviews branch from 58817f4 to 59914dc Compare February 27, 2024 15:55

Base automatically changed from db-types-migrate-dataset-and-source to master February 27, 2024 15:59

sophiamersmann and others added 2 commits February 27, 2024 16:00

🔨 (db) migrate Pageview to knex

55b756f

🔨 incorporate PR feedback

afa89e1

danyx23 force-pushed the db-migrate-pageviews branch from 59914dc to afa89e1 Compare February 27, 2024 16:00

danyx23 merged commit 272c88f into master Feb 27, 2024
14 of 16 checks passed

danyx23 deleted the db-migrate-pageviews branch February 27, 2024 16:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🔨 (db) migrate Pageview to knex #3139

🔨 (db) migrate Pageview to knex #3139

sophiamersmann commented Jan 26, 2024 •

edited

Loading

sophiamersmann commented Jan 26, 2024 •

edited

Loading

coderabbitai bot commented Jan 26, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

github-actions bot commented Feb 13, 2024

sophiamersmann left a comment

sophiamersmann Feb 27, 2024

sophiamersmann Feb 27, 2024

danyx23 commented Feb 27, 2024 •

edited

Loading

🔨 (db) migrate Pageview to knex #3139

🔨 (db) migrate Pageview to knex #3139

Conversation

sophiamersmann commented Jan 26, 2024 • edited Loading

sophiamersmann commented Jan 26, 2024 • edited Loading

coderabbitai bot commented Jan 26, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

github-actions bot commented Feb 13, 2024

sophiamersmann left a comment

Choose a reason for hiding this comment

sophiamersmann Feb 27, 2024

Choose a reason for hiding this comment

sophiamersmann Feb 27, 2024

Choose a reason for hiding this comment

danyx23 commented Feb 27, 2024 • edited Loading

Merge activity

sophiamersmann commented Jan 26, 2024 •

edited

Loading

sophiamersmann commented Jan 26, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

danyx23 commented Feb 27, 2024 •

edited

Loading