Extract grapher and core table types #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyx23
force-pushed
the
extract-grapher-and-core-table-types
branch
from
97da006 to
51d723c
Compare
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
danyx23
force-pushed
the
extract-grapher-and-core-table-types
branch
from
51d723c to
1d68047
Compare
danyx23
force-pushed
the
extract-grapher-and-core-table-types
branch
from
168bd71 to
a5ba090
Compare
ikesau
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
lgtm! app compiles & runs, DB migrations run fine 🙂👍
searching type \w+ = in ./packages/@ourworldindata/grapher/src shows a few places still where we have collections of type declarations in the grapher core library (e.g. StackedConstants.ts and MarimekkoChartConstants.ts)
Are those excepted because they're very specific to an internal usecase and closeness is more valuable? Not a blocker either way
|
Ah yes, nice catch, I have missed some types. I'll merge these and then we can move the remaining ones over in a follow up |
danyx23
force-pushed
the
types-package
branch
from
96ebec0 to
58da469
Compare
danyx23
force-pushed
the
extract-grapher-and-core-table-types
branch
from
a5ba090 to
f3522c9
Compare
danyx23
added a commit
that referenced
this pull request
Jan 12, 2024
This PR breaks the messy `owidTypes.ts` file up into around 20 files and moves them into the `types` package. This PR has some issues on the tests that were fixed in the next PR in the stack (#3056) - it is only supposed to be merged as part of the entire stack.
The rest of the codebase still has to be adapted
danyx23
force-pushed
the
extract-grapher-and-core-table-types
branch
from
0c64f41 to
0ee6c51
Compare
This was referenced Jan 24, 2024
This was referenced Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts all types from the
grapherandcore-tablepackages and moves them into thetypespackage. This will allow us to freely re-use types finally, e.g. so that theChartsRowtype defined in types can specify that thecontentfield is aGrapherInterface.