Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚒️ Move types out of utils and into their own types package #3054

Merged
merged 11 commits into from
Jan 12, 2024

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Dec 29, 2023

This PR breaks the messy owidTypes.ts file up into around 20 files and moves them into the types package. This PR has some issues on the tests that were fixed in the next PR in the stack (#3056) - it is only supposed to be merged as part of the entire stack.

Copy link
Contributor Author

danyx23 commented Jan 4, 2024

Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I fixed one import that was broken and added a couple of tiny touch-ups

:shipit:

Copy link
Contributor Author

danyx23 commented Jan 12, 2024

Merge activity

  • Jan 12, 12:47 PM: @danyx23 started a stack merge that includes this pull request via Graphite.
  • Jan 12, 12:47 PM: @danyx23 merged this pull request with Graphite.

@danyx23 danyx23 merged commit 7b3b887 into master Jan 12, 2024
23 checks passed
@danyx23 danyx23 deleted the types-package branch January 12, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants