-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Refactor] Version and LegacyESVersion from server module to core lib (#7328) #8382
[Backport 2.x] [Refactor] Version and LegacyESVersion from server module to core lib (#7328) #8382
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Unrelated CI/CD failure. Documented on #8352 (comment) refiring |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #8382 +/- ##
============================================
+ Coverage 70.47% 70.58% +0.11%
- Complexity 56953 57017 +64
============================================
Files 4737 4737
Lines 270103 270094 -9
Branches 39905 39901 -4
============================================
+ Hits 190345 190638 +293
+ Misses 63404 63065 -339
- Partials 16354 16391 +37
|
…opensearch-project#7328) Refactors the Version and LegacyESVersion classes from the server module to the core library. All gradle build scripts and dependencies are updated. This commit serves as a foundation for refactoring all OpenSearch base classes from the server module into appropriate libraries to decouple core search logic from the cluster model so it can be reused in serverless and cloud native environments. Signed-off-by: Nicholas Walter Knize <[email protected]>
/cc @andrross I need these reviewed so I can finish the remaining backports. Downstreams never kept up with the incremental changes on main so they have PRs that conflate these changes. e.g., see opensearch-project/ml-commons#901 (comment) |
5009859
to
caabc00
Compare
Gradle Check (Jenkins) Run Completed with:
|
@nknize I just wonder if eventually all Strings related methods will refactor to core lib, or if they are not refactored now, they will keep staying in their original library for a while? |
Backport 142ae46 from #7328.
relates #7818