Backport core String lib refactor fix PR and migrate all ImmutableMap with j.u.map #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with j.u.map Signed-off-by: Sicheng Song <[email protected]>
|
Hi @nknize I kindly want you to help review this PR to see if any migration is inappropriate. |
|
Please notice that integ test fail at this moment because container is not updated. We can wait until all tests are passed. |
Signed-off-by: Sicheng Song <[email protected]>
|
All tests passed, build success. |
|
@nknize We think a better idea is to use a separate PR to do the migration so that you can review it whenever you are free. Close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should fix refactor changes in this core backport PR opensearch-project/OpenSearch#8382, meanwhile we've migrated all
ImmutableMapwithjava.util.HashMapand useCollections.unmodifableMapor usejava.util.Map.of(...by @nknize 's recommendation in opensearch-project/OpenSearch#7309.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.