Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the refactor change brought by core backport #1047

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Jul 7, 2023

Description

This PR should fix refactor changes in this core backport PR opensearch-project/OpenSearch#8382

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

b4sjoo added 2 commits July 7, 2023 21:52
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #1047 (adc80ba) into 2.x (e6dabc0) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head adc80ba differs from pull request most recent head 89d1fd4. Consider uploading reports for the commit 89d1fd4 to get more accurate results

@@             Coverage Diff              @@
##                2.x    #1047      +/-   ##
============================================
- Coverage     82.32%   82.26%   -0.06%     
  Complexity     1918     1918              
============================================
  Files           149      149              
  Lines          7506     7507       +1     
  Branches        750      750              
============================================
- Hits           6179     6176       -3     
- Misses          987      990       +3     
- Partials        340      341       +1     
Flag Coverage Δ
ml-commons 82.26% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...org/opensearch/ml/cluster/DiscoveryNodeHelper.java 95.23% <ø> (ø)
...ain/java/org/opensearch/ml/task/MLTaskManager.java 70.39% <ø> (ø)
...nsearch/ml/autoredeploy/MLModelAutoReDeployer.java 91.08% <100.00%> (ø)
.../java/org/opensearch/ml/utils/RestActionUtils.java 83.01% <100.00%> (+0.32%) ⬆️

... and 1 file with indirect coverage changes

@b4sjoo b4sjoo merged commit 8139f8f into opensearch-project:2.x Jul 7, 2023
@b4sjoo b4sjoo deleted the 2.x_breakingfix branch July 7, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants