Feat/linear damping #239
Merged
Feat/linear damping #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My assumption with fsrs_params_5 is that we can continue to use it for future FSRS 5.x releases. We haven't had a stable release with 5 yet, so I think this change is fine - we can suggest users optimise again after updating to the next beta/RC. |
Yes, it's exactly what I wanted to say. |
asukaminato0721
approved these changes
Oct 22, 2024
dae
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close open-spaced-repetition/fsrs4anki#697
@dae, I make a minor change in the model of FSRS-5. I prefer not to update the algorithm version (e.g. FSRS-5.1, FSRS-5.5 or something else) because Anki has stored FSRS-5 parameters separately and FSRS-5 hasn't been released in stable version of Anki. What do you think of?