Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/linear damping #133

Merged
merged 8 commits into from
Nov 30, 2024
Merged

Feat/linear damping #133

merged 8 commits into from
Nov 30, 2024

Conversation

ishiko732
Copy link
Collaborator

@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4663f21) to head (4c0abf0).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #133   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          652       656    +4     
  Branches        70        70           
=========================================
+ Hits           652       656    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@L-M-Sherlock
Copy link
Member

Please wait for the stable release of Anki and I will update the optimizer.

L-M-Sherlock
L-M-Sherlock reviewed Oct 26, 2024
View reviewed changes
src/fsrs/algorithm.ts Outdated Show resolved Hide resolved
@xiety xiety mentioned this pull request Nov 6, 2024
Closed
@ishiko732
Copy link
Collaborator Author

Please wait for the stable release of Anki and I will update the optimizer.

Anki has released a new version. https://github.com/ankitects/anki/releases/tag/24.11

L-M-Sherlock
L-M-Sherlock approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L-M-Sherlock L-M-Sherlock merged commit f0b1369 into main Nov 30, 2024
5 checks passed
@ishiko732 ishiko732 deleted the Feat/linear-damping branch November 30, 2024 10:38
This was referenced Dec 1, 2024
Closed
Closed
@ishiko732 ishiko732 mentioned this pull request Dec 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-M-Sherlock L-M-Sherlock L-M-Sherlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishiko732 @L-M-Sherlock