Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the visualizer to match the latest version of FSRS-5 #9

Closed
Expertium opened this issue Nov 5, 2024 · 4 comments · Fixed by #10
Closed

Update the visualizer to match the latest version of FSRS-5 #9

Expertium opened this issue Nov 5, 2024 · 4 comments · Fixed by #10

Comments

@Expertium
Copy link

Expertium commented Nov 5, 2024

https://github.com/open-spaced-repetition/fsrs-optimizer
I don't think that the current version of the visualizer is fully up-to-date

@xiety
Copy link
Collaborator

xiety commented Nov 5, 2024

This repository uses version 4.4.2 of this library: https://github.com/open-spaced-repetition/ts-fsrs

And it is the latest version for today: https://github.com/open-spaced-repetition/ts-fsrs/releases

What exactly is not up to date? Can you give some example?

@Expertium
Copy link
Author

https://huggingface.co/spaces/open-spaced-repetition/fsrs4anki_previewer
FSRS-5 parameters: 0.40255, 1.18385, 3.173, 15.69105, 7.1949, 0.5345, 1.4604, 0.0046, 1.54575, 0.1192, 1.01925, 1.9395, 0.11, 0.29605, 2.2698, 0.2315, 2.9898, 0.51655, 0.6621
Desired retention: 0.9
Ratings: 1,2,1,2
Output:

rating history: 1,2,1,2
interval history: 0.0d,1.0d,1.0d,1.0d,1.0d
factor history: 0.0,0.0,1.00,1.00,1.00
difficulty history: 0,7.2,7.6,8.4,8.6

7.2 is 69%, 7.6 is 73%, 8.4 is 82%, 8.6 is 84%.

Visualizer:
image

The difficulty formula has recently been updated. Perhaps ts-FSRS hasn't been updated?

@xiety
Copy link
Collaborator

xiety commented Nov 6, 2024

I found that FSRS-Optimizer added linear damping here: open-spaced-repetition/fsrs-optimizer#143

It is already implemented in open-spaced-repetition/fsrs-rs#239 and in open-spaced-repetition/fsrs4anki#702

But neither ts-fsrs nor py-fsrs nor rs-fsrs have added it yet.

So I will wait for open-spaced-repetition/ts-fsrs#133 to catch up with it.

@ishiko732
Copy link
Contributor

Perhaps ts-FSRS hasn't been updated?

ts-fsrs has not yet approved the merge of linear damping. Please wait for the stable release of Anki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants