Remove prepare script #1606
Closed
Remove prepare script #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-victorlin-remov-lkcqdl
The prepare script is automatically run with every call to npm ci / npm install, among other scripts¹. As it is just an alias to the build script (which can take several minutes), it should be safe to remove this automation and speed up the dev experience. Some parts of the README and CI workflow had relied on the prepare script automation. Updated accordingly. ¹ https://docs.npmjs.com/cli/v8/using-npm/scripts?v=true#life-cycle-operation-order
victorlin
force-pushed
the
victorlin/remove-prepare-script
branch
from
dc99c86 to
35453f9
Compare
nextstrain-bot
temporarily deployed
to
auspice-victorlin-remov-lkcqdl
7 tasks
|
Closing this since the prepare script is still needed per discussion. A more reasonable approach would be to document the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The prepare script is automatically run with every call to
npm ci/npm install, among other scripts¹. As it is just an alias to the build script (which can take several minutes), it should be safe to remove this automation and speed up the dev experience.Updated README accordingly.
¹ https://docs.npmjs.com/cli/v8/using-npm/scripts?v=true#life-cycle-operation-order
Related issue(s)
N/A
Testing